linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcus Overhagen <marcus.overhagen@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
	Ulrik De Bie <ulrik.debie-os@e2big.org>,
	Hans de Goede <hdegoede@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-input <linux-input@vger.kernel.org>,
	Jiri Kosina <jkosina@suse.cz>
Subject: Re: [git pull] Input updates for 3.18-rc4
Date: Wed, 19 Nov 2014 20:23:32 +0100	[thread overview]
Message-ID: <CAJBHPog3qRMQgNnso_csUOgR30A6eFPx4PkTzfCzkB3Gd5oVfQ@mail.gmail.com> (raw)
In-Reply-To: <20141119183921.GF37989@dtor-ws>

Hi Dmitry,

luckily I found some time right now. I haven't reverted the original large
patch, but I tested your short patch and it fixes the problem for me.

regards
Marcus

On Wed, Nov 19, 2014 at 7:39 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Wed, Nov 19, 2014 at 07:20:21PM +0100, Marcus Overhagen wrote:
>> Hi,
>>
>> I will try reverting that, but may need until tomorrow or Friday.
>>
>> Just now I made a warm reboot from rc3 to rc5 and initially scrolling
>> behaviour was ok,  but after about a minute it went wrong and I got
>> this:
>>
>> [  179.705362] ------------[ cut here ]------------
>> [  179.705382] WARNING: CPU: 3 PID: 0 at
>> drivers/input/mouse/elantech.c:433
>> elantech_report_trackpoint.isra.5+0x199/0x1b0 [psmouse]()
>> [  179.705385] psmouse serio1: elantech: Unexpected trackpoint message
>
> Or just this for now:
>
> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> index 3fcb6b3..294f613 100644
> --- a/drivers/input/mouse/elantech.c
> +++ b/drivers/input/mouse/elantech.c
> @@ -793,7 +793,7 @@ static int elantech_packet_check_v4(struct psmouse *psmouse)
>         unsigned char packet_type = packet[3] & 0x03;
>         bool sanity_check;
>
> -       if ((packet[3] & 0x0f) == 0x06)
> +       if ((packet[3] & 0x0f) == 0x06 && etd->tp_dev)
>                 return PACKET_TRACKPOINT;
>
>         /*
>
> --
> Dmitry

  reply	other threads:[~2014-11-19 19:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14 22:26 [git pull] Input updates for 3.18-rc4 Dmitry Torokhov
2014-11-19 15:32 ` Benjamin Tissoires
2014-11-19 18:00   ` Marcus Overhagen
2014-11-19 18:12     ` Dmitry Torokhov
2014-11-19 18:20       ` Marcus Overhagen
2014-11-19 18:39         ` Dmitry Torokhov
2014-11-19 19:23           ` Marcus Overhagen [this message]
2014-11-19 21:05             ` ulrik.debie-os
2014-11-19 21:49               ` Marcus Overhagen
2014-11-19 21:54                 ` ulrik.debie-os
2014-11-19 22:21                   ` Marcus Overhagen
2014-11-25 21:23                     ` ulrik.debie-os
2014-11-26 14:33                       ` Benjamin Tissoires
2014-11-27 20:41                         ` ulrik.debie-os
2014-11-20 14:44               ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJBHPog3qRMQgNnso_csUOgR30A6eFPx4PkTzfCzkB3Gd5oVfQ@mail.gmail.com \
    --to=marcus.overhagen@gmail.com \
    --cc=benjamin.tissoires@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ulrik.debie-os@e2big.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).