From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D353C2D0CD for ; Sun, 15 Dec 2019 23:25:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F6452467A for ; Sun, 15 Dec 2019 23:25:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=konsulko.com header.i=@konsulko.com header.b="N+c4HK+q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726537AbfLOXZk (ORCPT ); Sun, 15 Dec 2019 18:25:40 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:41304 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726478AbfLOXZj (ORCPT ); Sun, 15 Dec 2019 18:25:39 -0500 Received: by mail-io1-f65.google.com with SMTP id c16so5016267ioo.8 for ; Sun, 15 Dec 2019 15:25:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WEL4itFmihZqlf+pK1DU7DEDt/SepncHaF9ZMAufTQk=; b=N+c4HK+qYE45RWqlaHU7AnTEY46OfO0t0kBAN2F+qSebIf6nmrna9JaUNv7TDH9X27 eCgTN0xBKqFk/ruLZ7CepWQ0jgS9fLOYi7yjsjSN9bKiqaIzJ/+CIrt8kekjVO41P6NN d5Eo49hMKI8IYCNwJ9GMtn/oFArpJVH77Ajsw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WEL4itFmihZqlf+pK1DU7DEDt/SepncHaF9ZMAufTQk=; b=JEEwKH7FjomZXTyAaSqkPXtvU68EWbb+Dh9tnP6E6TP8qyQgh4AaP3x7Ea6+IqU0Sp QCGOw8OV/Hf8JXkzjyY5YjnUc70Yu83icHP6DYcod2F2Xs6Co09ULPqWPjg/RXUVEfab UXL6AmrAB+qbVenEO5YnxHA9UZBnp/K2nu+zIrrhRC3eFWOTerypEIdwqK/aDLEAvejk 8JsMkdssRLZQpQmJfIe1Cf+eM7poaXu4SACyampsM+7kxhUinrK9uGNsbnOidNYHCafa Qmsx3/oFA2Loyke1eGRA66iofzV7jzNT0I625xmA5IkmFVw2nuSQ7G7cNyrmW73Gti+8 G0Rg== X-Gm-Message-State: APjAAAVDUBKDukwuFn6Z7+XZoOdjrpAziqPN+AzvPt6si81yHaku3ieP RhkIy5oWvnDExaDxl56FD0McmUgrTd8POXlYik1M4w== X-Google-Smtp-Source: APXvYqyxqgqtul5GG7UvGBKwhR/jHF82eADU4suOa7b5QH1cqUuBRY6sCnLgmir+XVDsPtFBuRQBjcI89ud2U+OOQlo= X-Received: by 2002:a05:6638:72c:: with SMTP id j12mr9795715jad.136.1576452338679; Sun, 15 Dec 2019 15:25:38 -0800 (PST) MIME-Version: 1.0 References: <20191210210735.9077-1-sashal@kernel.org> <20191210210735.9077-66-sashal@kernel.org> <20191215155329.4c71ad53@archlinux> In-Reply-To: <20191215155329.4c71ad53@archlinux> From: Matt Ranostay Date: Sun, 15 Dec 2019 15:25:27 -0800 Message-ID: Subject: Re: [PATCH AUTOSEL 5.4 105/350] iio: chemical: atlas-ph-sensor: fix iio_triggered_buffer_predisable() position To: Jonathan Cameron Cc: Sasha Levin , open list , stable@vger.kernel.org, Alexandru Ardelean , Jonathan Cameron , "open list:IIO SUBSYSTEM AND DRIVERS" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 15, 2019 at 7:53 AM Jonathan Cameron wrote: > > On Tue, 10 Dec 2019 16:03:30 -0500 > Sasha Levin wrote: > > > From: Alexandru Ardelean > > > > [ Upstream commit 0c8a6e72f3c04bfe92a64e5e0791bfe006aabe08 ] > > > > The iio_triggered_buffer_{predisable,postenable} functions attach/detach > > the poll functions. > > > > The iio_triggered_buffer_predisable() should be called last, to detach the > > poll func after the devices has been suspended. > > > > The position of iio_triggered_buffer_postenable() is correct. > > > > Note this is not stable material. It's a fix in the logical > > model rather fixing an actual bug. These are being tidied up > > throughout the subsystem to allow more substantial rework that > > was blocked by variations in how things were done. > > See comment. This is not what I would consider stable material. > Outside of the comment, which really isn't probably enough to avoid the autoselection script from detecting it (could be "stable" in the message alone selects it :) ), is there any way to signal that a patch is "NOT for stable trees"? Probably don't want to clutter up the commit messages of course. - Matt > > > > Signed-off-by: Alexandru Ardelean > > Acked-by: Matt Ranostay > > Signed-off-by: Jonathan Cameron > > Signed-off-by: Sasha Levin > > --- > > drivers/iio/chemical/atlas-ph-sensor.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c > > index 3a20cb5d9bffc..6c175eb1c7a7f 100644 > > --- a/drivers/iio/chemical/atlas-ph-sensor.c > > +++ b/drivers/iio/chemical/atlas-ph-sensor.c > > @@ -323,16 +323,16 @@ static int atlas_buffer_predisable(struct iio_dev *indio_dev) > > struct atlas_data *data = iio_priv(indio_dev); > > int ret; > > > > - ret = iio_triggered_buffer_predisable(indio_dev); > > + ret = atlas_set_interrupt(data, false); > > if (ret) > > return ret; > > > > - ret = atlas_set_interrupt(data, false); > > + pm_runtime_mark_last_busy(&data->client->dev); > > + ret = pm_runtime_put_autosuspend(&data->client->dev); > > if (ret) > > return ret; > > > > - pm_runtime_mark_last_busy(&data->client->dev); > > - return pm_runtime_put_autosuspend(&data->client->dev); > > + return iio_triggered_buffer_predisable(indio_dev); > > } > > > > static const struct iio_trigger_ops atlas_interrupt_trigger_ops = { >