From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F08FCC10F14 for ; Thu, 18 Apr 2019 23:24:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C03AA21479 for ; Thu, 18 Apr 2019 23:24:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=konsulko.com header.i=@konsulko.com header.b="qoAE+0Wa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726441AbfDRXYD (ORCPT ); Thu, 18 Apr 2019 19:24:03 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:38457 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbfDRXYC (ORCPT ); Thu, 18 Apr 2019 19:24:02 -0400 Received: by mail-io1-f65.google.com with SMTP id v4so3237998ioj.5 for ; Thu, 18 Apr 2019 16:24:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nYnjpbYIMxNLgPvwoxMtw7pWJw8b1tMjbX+F/ysjFc4=; b=qoAE+0Wa17POtFqv+4fJDrbB5jBS8MNmXgD5r82vEX7dy4nC+V6dpsX28bMbT4a2Yp 9ra60l1BE5PvfQZjJHoo6U/JYkNDdmbIwkNzkwBiLMrxgAZXY70JgtioR3sXfQVYpCiN mlBDWjE/fAbhwgm2IaWEhK0DgJvn8laRqhqfk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nYnjpbYIMxNLgPvwoxMtw7pWJw8b1tMjbX+F/ysjFc4=; b=EA0F34Sq0H04jFhLRMfHO1wIW/jiNklA/bfg6ASGEFZZ3MNmtwVCFkARfCPXfNA2Fs 2puDo4x7xqt/ce2y/TZXFao6rBkXEZtGF4VSVOtrWe2dmAvkkqZX2YupqrAUh1nehPSj k2slXxmVPW3EDTDTq77x+Qeyy1VFH50i8eOY4RIZ4kwGkxqok4P4ddVcGAUjqPbOBnOb JyX7fUBmGePX/SXZr4qJ5z0YOyV1yo99a15SPRrBXP6j2z4Ly5U3SVEsS8wLYG3housX YqYjw+/dkGvGmMjSSlV6wXS7Azb3fvUDnxZB/eicshAkR5dV1k1SFg3Ym/a1ynxNrwZ6 c5kA== X-Gm-Message-State: APjAAAXh3KCGcAOnyj8ftpUrpdQqd4WFYY/6EmjqR7TmeoGzrvOzmUEn Ecb6Asj6o+5VR3EkqA7W2PT768zfbHMPBU0FMc+3RA== X-Google-Smtp-Source: APXvYqzJSMPZoVqHWxB/rrLHTWGRZBbREhfa+XWc2dlrDl5GhW9qka6R/0BuNpknkxKA90uUINfodzlmDxZaV+0GN/U= X-Received: by 2002:a6b:b454:: with SMTP id d81mr681469iof.109.1555629841879; Thu, 18 Apr 2019 16:24:01 -0700 (PDT) MIME-Version: 1.0 References: <1555524925-15450-1-git-send-email-mohankumar718@gmail.com> In-Reply-To: <1555524925-15450-1-git-send-email-mohankumar718@gmail.com> From: Matt Ranostay Date: Thu, 18 Apr 2019 16:23:51 -0700 Message-ID: Subject: Re: [PATCH] drivers: iio: proximity: This patch fix the following checkpatch warning. To: Mohan Kumar Cc: Andreas Klinger , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org See comments inline On Wed, Apr 17, 2019 at 11:15 AM Mohan Kumar wrote: > > As per Documentation/timers/timers-howto.txt Msleep < 20ms can sleep for > up to 20ms. so use usleep_range. > > Signed-off-by: Mohan Kumar > --- > drivers/iio/proximity/mb1232.c | 2 +- > drivers/iio/proximity/srf08.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/proximity/mb1232.c b/drivers/iio/proximity/mb1232.c > index 166b3e6..74f7eae 100644 > --- a/drivers/iio/proximity/mb1232.c > +++ b/drivers/iio/proximity/mb1232.c > @@ -81,7 +81,7 @@ static s16 mb1232_read_distance(struct mb1232_data *data) > } > } else { > /* use simple sleep if announce irq is not connected */ > - msleep(15); > + usleep_range(15000, 20000); This is actually less than ideal.. because usleep_range uses the hrtimers which forces an interrupt. Unless you actually need to read between 15ms and 20ms it is best just to leave the msleep() as it is, and let it take a bit longer if required. - Matt > } > > ret = i2c_master_recv(client, (char *)&buf, sizeof(buf)); > diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c > index f2bf783..605a582 100644 > --- a/drivers/iio/proximity/srf08.c > +++ b/drivers/iio/proximity/srf08.c > @@ -150,7 +150,7 @@ static int srf08_read_ranging(struct srf08_data *data) > * polling for not more than 20 ms should be enough > */ > waittime = 1 + data->range_mm / 172; > - msleep(waittime); > + usleep_range(waittime * 1000, (waittime * 1000) + 2000); > for (i = 0; i < 4; i++) { > ret = i2c_smbus_read_byte_data(data->client, > SRF08_READ_SW_REVISION); > @@ -158,7 +158,7 @@ static int srf08_read_ranging(struct srf08_data *data) > /* check if a valid version number is read */ > if (ret < 255 && ret > 0) > break; > - msleep(5); > + usleep_range(5000, 15000); > } > > if (ret >= 255 || ret <= 0) { > -- > 2.7.4 >