From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EBACC433F5 for ; Mon, 10 Oct 2022 20:10:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229614AbiJJUKe (ORCPT ); Mon, 10 Oct 2022 16:10:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbiJJUKb (ORCPT ); Mon, 10 Oct 2022 16:10:31 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B6874056D for ; Mon, 10 Oct 2022 13:10:29 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id o20-20020a05600c4fd400b003b4a516c479so7022809wmq.1 for ; Mon, 10 Oct 2022 13:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wGNDpOeLOE7OjB7U7YvgsHvvZffGfTvB2dUjZAsgtBo=; b=Vupn4GEXNM5D4Wr4r7BDfXIXw6xDZQbzb9I3fNBJNLoi5l8ds/Tkg8cwXCJzmPJjko alBcGmCc5zwkw5ONkM6qK2mMqO9JxXal5ALOmIu/ZEr56BRWFreuPGoE4pXwrXFWsCoi QMhj+nE1gcYH3kV4FJX0O93ZY2uGsGAHEI6y09HwYo5mwwd13sj5XJgGeuVTJSGbIlE9 ixDhG/ZbMamNyJ3baduZdgE7NEdKV2DCnqKpbDn2emffP+E9qIOqENq3OdpIQRCev1JN z/xLm93S2iPbUd7YUcn3CSeUBYx1HSAhv0ydlJhUd+7KszeV4xCGDRxrT48qRl89b/ZS MCoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wGNDpOeLOE7OjB7U7YvgsHvvZffGfTvB2dUjZAsgtBo=; b=sm3iy/73QwtXEN5h3JDGavHB8WwxNxQZgBJivKqgkGHAaDTWKNyLWInWbk+sn7hafk aGEX/DAmTVVPH56DxDLrYs+S9wOfaCrAJArMLvlUqM+HfeG4fHD6ox28NgK5Kx9IO2tm 879nc1Fq7kUOb5Hlxq+EmoaUuI7k6KCAdaSGPSp5BAn27St47rr1Xd4ZFsVv6ELrA24v 5shtnhB9qZEQbzQzRySstsaxCCBs9U9J3xCzaJ1hR0aFw3wOZh+4vczmwCbVIb6lgEjm SlKND/fZC+/FNzfWjBiUMV7i3ey7qsL7hB9iTL6Q2FQ0xrD18bW2ekhNUMNvJbrPKimc jUSA== X-Gm-Message-State: ACrzQf00EiVHraLOuRgBA6QN94ou8u5C/D2fNOYMh+tXkkT6uT8mVV6i Lb2gZ/ztC8UyndWjVgG0+A712vG1Ak3jNpXtkqAC6w== X-Google-Smtp-Source: AMsMyM4atS4e8o+jD0nBGHZ7ckqJ+XrPgYGnLwvGp/au332aDL7G5yx6JvjxGIt85pNZgMR5WpISOAdPf+K60wY6Uqw= X-Received: by 2002:a05:600c:524d:b0:3b4:91ee:933e with SMTP id fc13-20020a05600c524d00b003b491ee933emr14293071wmb.80.1665432627707; Mon, 10 Oct 2022 13:10:27 -0700 (PDT) MIME-Version: 1.0 References: <000000000000385cbf05ea3f1862@google.com> <00000000000028a44005ea40352b@google.com> <20221009084039.cw6meqbvy4362lsa@wittgenstein> In-Reply-To: From: Yosry Ahmed Date: Mon, 10 Oct 2022 13:09:51 -0700 Message-ID: Subject: Re: [PATCH] cgroup: Fix crash with CLONE_INTO_CGROUP and v1 cgroups To: Tejun Heo Cc: "Christian A. Ehrhardt" , Christian Brauner , syzbot , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Martin KaFai Lau Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2022 at 1:07 PM Tejun Heo wrote: > > Hello, > > On Mon, Oct 10, 2022 at 12:57:34PM -0700, Yosry Ahmed wrote: > > Any suggestions for the new names though? Given that the new ones > > would be the ones that will support both versions, I am not sure how > > to name them differently in a meaningful way. Maybe something like > > cgroup_get_all_from_[fd/file]() ? > > idk, cgroup12_get_from_[fd/file]()? > > > IMO, we can rename the current versions to > > cgroup_get_dfl_from_[fd/file](), and the new ones (which support both) > > as cgroup_get_from_fd/file(). In this case it's obvious that one > > version specifically works on "dfl", aka cgroup2. > > It's kinda confusing because we've been assuming that these lookup functions > are all cgroup2 only. > > Thanks. Got it. Will send a patch shortly. Thanks! > > -- > tejun