linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guo Ren <guoren@kernel.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-csky@vger.kernel.org, Guo Ren <guoren@linux.alibaba.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH v2 2/2] drivers/clocksource: Fixup csky,mptimer compile error with CPU_CK610
Date: Sun, 7 Feb 2021 11:34:53 +0800	[thread overview]
Message-ID: <CAJF2gTRru-5aT_R=AoCWC6e08oF_isBfL_ALUvdqCSmxBuEgtg@mail.gmail.com> (raw)
In-Reply-To: <CAJF2gTSe7GUzPRvk6bK8AfQFp2uxae1Oo0w-ZtrtmcJmMWCqPw@mail.gmail.com>

The same way in IRQ chip:

Link: https://lore.kernel.org/lkml/161245410060.1472442.13488057609914274236.b4-ty@kernel.org/

On Sun, Feb 7, 2021 at 11:31 AM Guo Ren <guoren@kernel.org> wrote:
>
> Hi Daniel,
>
> On Thu, Feb 4, 2021 at 4:48 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> >
> > On 04/02/2021 08:46, guoren@kernel.org wrote:
> > > From: Guo Ren <guoren@linux.alibaba.com>
> > >
> > > The timer-mp-csky.c only could support CPU_CK860 and it will
> > > compile error with CPU_CK610.
> > >
> > > It has been selected in arch/csky/Kconfig.
> >
> > It would be better if you fix the root cause of the compilation error.
> The timer-mp-csky.c has used specific instructions which only
> supported by CK860 and timer-mp-csky.c is only design for CK860.
>
> In arch/csky/Konfig we only select it with CK860.
>         select CSKY_MPINTC if CPU_CK860
>         select CSKY_MP_TIMER if CPU_CK860
>
> So here let's select timer-mp-csky.c in arch/csky/Kconfig, not in
> drivers/clocksource/Kconfig.
>
>
> --
> Best Regards
>  Guo Ren
>
> ML: https://lore.kernel.org/linux-csky/



-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/

  reply	other threads:[~2021-02-07  3:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  7:46 [PATCH v2 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU_CK610 guoren
2021-02-04  7:46 ` [PATCH v2 2/2] drivers/clocksource: Fixup csky,mptimer " guoren
2021-02-04  8:48   ` Daniel Lezcano
2021-02-07  3:31     ` Guo Ren
2021-02-07  3:34       ` Guo Ren [this message]
2021-02-07  9:29       ` Daniel Lezcano
2021-02-09 16:02         ` Guo Ren
2021-02-09 20:26           ` Daniel Lezcano
2021-02-10  3:03             ` Guo Ren
2021-02-04 15:55 ` (subset) [PATCH v2 1/2] drivers/irqchip: Fixup csky,mpintc " Marc Zyngier
2021-02-04 16:02 ` [irqchip: irq/irqchip-next] irqchip/csky-mpintc: Prevent selection on unsupported platforms irqchip-bot for Guo Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJF2gTRru-5aT_R=AoCWC6e08oF_isBfL_ALUvdqCSmxBuEgtg@mail.gmail.com' \
    --to=guoren@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=guoren@linux.alibaba.com \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).