From: Guo Ren <guoren@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-csky@vger.kernel.org, Guo Ren <guoren@linux.alibaba.com>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH] irqchip/irq-csky-mpintc: Fixup mask/unmask un-implementation
Date: Mon, 25 Oct 2021 21:14:19 +0800 [thread overview]
Message-ID: <CAJF2gTRvFGoyy44i3oRiAYkGnfts4hc-aB74RLHgsz8+AJxb=w@mail.gmail.com> (raw)
In-Reply-To: <87czntbdgk.wl-maz@kernel.org>
On Mon, Oct 25, 2021 at 6:34 PM Marc Zyngier <maz@kernel.org> wrote:
>
> On Mon, 25 Oct 2021 10:12:19 +0100,
> guoren@kernel.org wrote:
> >
> > From: Guo Ren <guoren@linux.alibaba.com>
> >
> > The mask/unmask must be implemented, and enable/disable supplement
> > them if the HW requires something different at startup time. When
> > irq source is disabled by mask, mpintc could complete irq normally.
> >
> > So just replace the with mask/unmask function.
> >
> > Tested-by: Guo Ren <guoren@linux.alibaba.com>
>
> This only makes sense if tested by a third party. It is assumed that
> the author of a patch has tested it.
Thx for pointing it out.
>
> > Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
>
> This hasn't been my email address for over two years now. I'm sure my
> ex manager is happy to hear from you, but I doubt he'll bother replying.
I'll fix up your email in the next patch, thx for still reviewing.
>
> > ---
> > drivers/irqchip/irq-csky-mpintc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/irqchip/irq-csky-mpintc.c b/drivers/irqchip/irq-csky-mpintc.c
> > index a1534edef7fa..f169600dbde6 100644
> > --- a/drivers/irqchip/irq-csky-mpintc.c
> > +++ b/drivers/irqchip/irq-csky-mpintc.c
> > @@ -164,8 +164,8 @@ static int csky_irq_set_affinity(struct irq_data *d,
> > static struct irq_chip csky_irq_chip = {
> > .name = "C-SKY SMP Intc",
> > .irq_eoi = csky_mpintc_eoi,
> > - .irq_enable = csky_mpintc_enable,
> > - .irq_disable = csky_mpintc_disable,
> > + .irq_unmask = csky_mpintc_enable,
> > + .irq_mask = csky_mpintc_disable,
> > .irq_set_type = csky_mpintc_set_type,
> > #ifdef CONFIG_SMP
> > .irq_set_affinity = csky_irq_set_affinity,
>
> Please rename the functions to match the fields they are assigned to.
okay
>
> Thanks,
>
> M.
>
> --
> Without deviation from the norm, progress is not possible.
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
prev parent reply other threads:[~2021-10-25 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 9:12 [PATCH] irqchip/irq-csky-mpintc: Fixup mask/unmask un-implementation guoren
2021-10-25 10:34 ` Marc Zyngier
2021-10-25 13:14 ` Guo Ren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJF2gTRvFGoyy44i3oRiAYkGnfts4hc-aB74RLHgsz8+AJxb=w@mail.gmail.com' \
--to=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).