From: Guo Ren <guoren@kernel.org>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Arnd Bergmann <arnd@arndb.de>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v2 2/4] riscv: vmlinux-xip.lds.S: remove .alternative section
Date: Thu, 1 Jun 2023 12:43:00 +0800 [thread overview]
Message-ID: <CAJF2gTS1EcEw0VWGgd-bezKh=s7zPnFBdyuJc1wuH_SXEwoXbA@mail.gmail.com> (raw)
In-Reply-To: <20230523165502.2592-3-jszhang@kernel.org>
Reviewed-by: Guo Ren <guoren@kernel.org>
On Wed, May 24, 2023 at 1:10 AM Jisheng Zhang <jszhang@kernel.org> wrote:
>
> ALTERNATIVE mechanism can't work on XIP, and this is also reflected by
> below Kconfig dependency:
>
> RISCV_ALTERNATIVE
> ...
> depends on !XIP_KERNEL
> ...
>
> So there's no .alternative section at all for XIP case, remove it.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> arch/riscv/kernel/vmlinux-xip.lds.S | 6 ------
> 1 files changed, 6 deletions(-)
>
> diff --git a/arch/riscv/kernel/vmlinux-xip.lds.S b/arch/riscv/kernel/vmlinux-xip.lds.S
> index eab9edc3b631..50767647fbc6 100644
> --- a/arch/riscv/kernel/vmlinux-xip.lds.S
> +++ b/arch/riscv/kernel/vmlinux-xip.lds.S
> @@ -98,12 +98,6 @@ SECTIONS
> __soc_builtin_dtb_table_end = .;
> }
>
> - . = ALIGN(8);
> - .alternative : {
> - __alt_start = .;
> - *(.alternative)
> - __alt_end = .;
> - }
> __init_end = .;
>
> . = ALIGN(16);
> --
> 2.40.1
>
--
Best Regards
Guo Ren
next prev parent reply other threads:[~2023-06-01 4:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 16:54 [PATCH v2 0/4] riscv: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION Jisheng Zhang
2023-05-23 16:54 ` [PATCH v2 1/4] riscv: move options to keep entries sorted Jisheng Zhang
2023-05-25 14:01 ` Conor Dooley
2023-06-01 4:48 ` Guo Ren
2023-05-23 16:55 ` [PATCH v2 2/4] riscv: vmlinux-xip.lds.S: remove .alternative section Jisheng Zhang
2023-06-01 4:43 ` Guo Ren [this message]
2023-05-23 16:55 ` [PATCH v2 3/4] vmlinux.lds.h: use correct .init.data.* section name Jisheng Zhang
2023-05-24 11:02 ` Kefeng Wang
2023-05-23 16:55 ` [PATCH v2 4/4] riscv: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION Jisheng Zhang
2023-05-24 11:04 ` Kefeng Wang
2023-06-14 14:49 ` [PATCH v2 0/4] " Palmer Dabbelt
2023-06-14 16:25 ` Jisheng Zhang
2023-06-15 13:54 ` Palmer Dabbelt
2023-06-19 22:06 ` Palmer Dabbelt
2023-06-20 20:05 ` Nick Desaulniers
2023-06-20 20:13 ` Conor Dooley
2023-06-20 20:32 ` Nick Desaulniers
2023-06-20 20:41 ` Palmer Dabbelt
2023-06-20 20:47 ` Nick Desaulniers
2023-06-20 21:08 ` Palmer Dabbelt
2023-06-21 0:13 ` Palmer Dabbelt
2023-06-21 14:53 ` Palmer Dabbelt
2023-06-21 16:42 ` Conor Dooley
2023-06-21 17:23 ` Conor Dooley
2023-06-21 17:51 ` Björn Töpel
2023-06-21 18:19 ` Palmer Dabbelt
2023-06-21 19:46 ` Palmer Dabbelt
2023-06-22 21:40 ` Nick Desaulniers
2023-06-22 21:42 ` Palmer Dabbelt
2023-06-22 21:53 ` Nathan Chancellor
2023-06-22 22:16 ` Palmer Dabbelt
2023-06-22 23:18 ` Nathan Chancellor
2023-06-23 17:17 ` Nick Desaulniers
2023-06-25 12:24 ` Jisheng Zhang
2023-06-25 12:43 ` Conor Dooley
2023-06-25 20:05 ` Palmer Dabbelt
2023-06-25 20:06 ` Palmer Dabbelt
2023-07-22 0:37 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJF2gTS1EcEw0VWGgd-bezKh=s7zPnFBdyuJc1wuH_SXEwoXbA@mail.gmail.com' \
--to=guoren@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=conor.dooley@microchip.com \
--cc=jszhang@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).