From: Guo Ren <guoren@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: "Palmer Dabbelt" <palmerdabbelt@google.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Oleg Nesterov" <oleg@redhat.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Anup Patel" <anup@brainfault.org>,
linux-csky@vger.kernel.org,
"Greentime Hu" <greentime.hu@sifive.com>,
"Zong Li" <zong.li@sifive.com>, "Patrick Stählin" <me@packi.ch>,
"Björn Töpel" <bjorn.topel@gmail.com>,
"Guo Ren" <guoren@linux.alibaba.com>,
"Pekka Enberg" <penberg@kernel.org>
Subject: Re: [PATCH v3 6/7] riscv: Add KPROBES_ON_FTRACE supported
Date: Wed, 15 Jul 2020 00:24:54 +0800 [thread overview]
Message-ID: <CAJF2gTSMUnHfv3GLj_TGT2dJkKq2zbEsnbPKREiq5i6PPjyTBg@mail.gmail.com> (raw)
In-Reply-To: <20200714203757.512ce7fb5fa61a88b1dbb2f3@kernel.org>
Thx Masami,
On Tue, Jul 14, 2020 at 7:38 PM Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> On Mon, 13 Jul 2020 23:39:21 +0000
> guoren@kernel.org wrote:
>
> > From: Guo Ren <guoren@linux.alibaba.com>
> >
> > This patch adds support for kprobes on ftrace call sites to avoids
> > much of the overhead with regular kprobes. Try it with simple
> > steps:
> >
> > 1. Get _do_fork ftrace call site.
> > Dump of assembler code for function _do_fork:
> > 0xffffffe00020af64 <+0>: addi sp,sp,-128
> > 0xffffffe00020af66 <+2>: sd s0,112(sp)
> > 0xffffffe00020af68 <+4>: sd ra,120(sp)
> > 0xffffffe00020af6a <+6>: addi s0,sp,128
> > 0xffffffe00020af6c <+8>: sd s1,104(sp)
> > 0xffffffe00020af6e <+10>: sd s2,96(sp)
> > 0xffffffe00020af70 <+12>: sd s3,88(sp)
> > 0xffffffe00020af72 <+14>: sd s4,80(sp)
> > 0xffffffe00020af74 <+16>: sd s5,72(sp)
> > 0xffffffe00020af76 <+18>: sd s6,64(sp)
> > 0xffffffe00020af78 <+20>: sd s7,56(sp)
> > 0xffffffe00020af7a <+22>: mv s4,a0
> > 0xffffffe00020af7c <+24>: mv a0,ra
> > 0xffffffe00020af7e <+26>: nop <<<<<<<< here!
> > 0xffffffe00020af82 <+30>: nop
> > 0xffffffe00020af86 <+34>: ld s3,0(s4)
> >
> > 2. Set _do_fork+26 as the kprobe.
> > echo 'p:myprobe _do_fork+26 dfd=%a0 filename=%a1 flags=%a2 mode=+4($stack)' > /sys/kernel/debug/tracing/kprobe_events
> > echo 1 > /sys/kernel/debug/tracing/events/kprobes/enable
> > cat /sys/kernel/debug/tracing/trace
> > tracer: nop
> >
> > entries-in-buffer/entries-written: 3/3 #P:1
> >
> > _-----=> irqs-off
> > / _----=> need-resched
> > | / _---=> hardirq/softirq
> > || / _--=> preempt-depth
> > ||| / delay
> > TASK-PID CPU# |||| TIMESTAMP FUNCTION
> > | | | |||| | |
> > sh-87 [000] .... 551.557031: myprobe: (_do_fork+0x1a/0x2e6) dfd=0xffffffe00020af7e filename=0xffffffe00020b34e flags=0xffffffe00101e7c0 mode=0x20af86ffffffe0
> >
> > cat /sys/kernel/debug/kprobes/list
> > ffffffe00020af7e k _do_fork+0x1a [FTRACE]
> > ^^^^^^
>
> Hmm, this seems fentry is not supported on RISC-V yet. But anyway,
> it will be useful for users (if they can find the offset).
Seems only x86 & ⬆️90 use fentry,can you elaborate more about fentry's
benefit and how the user could set kprobe on ftrace call site without
disassemble?
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
next prev parent reply other threads:[~2020-07-14 16:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 23:39 [PATCH v3 0/7] riscv: Add k/uprobe supported guoren
2020-07-13 23:39 ` [PATCH v3 1/7] RISC-V: Implement ptrace regs and stack API guoren
2020-07-14 11:25 ` Masami Hiramatsu
2020-07-13 23:39 ` [PATCH v3 2/7] riscv: Fixup compile error BUILD_BUG_ON failed guoren
2020-07-13 23:39 ` [PATCH v3 3/7] riscv: Fixup kprobes handler couldn't change pc guoren
2020-07-14 11:32 ` Masami Hiramatsu
2020-08-14 22:36 ` Palmer Dabbelt
2020-08-17 12:47 ` Guo Ren
2020-07-13 23:39 ` [PATCH v3 4/7] riscv: Add kprobes supported guoren
2020-08-14 22:36 ` Palmer Dabbelt
2020-08-17 13:48 ` Guo Ren
2020-07-13 23:39 ` [PATCH v3 5/7] riscv: Add uprobes supported guoren
2020-07-13 23:39 ` [PATCH v3 6/7] riscv: Add KPROBES_ON_FTRACE supported guoren
2020-07-14 11:37 ` Masami Hiramatsu
2020-07-14 16:24 ` Guo Ren [this message]
2020-07-21 13:27 ` Masami Hiramatsu
2020-07-22 8:39 ` Guo Ren
2020-07-23 15:55 ` Masami Hiramatsu
2020-07-22 13:31 ` Guo Ren
2020-07-23 16:11 ` Masami Hiramatsu
2020-07-13 23:39 ` [PATCH v3 7/7] riscv: Add support for function error injection guoren
2020-07-14 11:43 ` Masami Hiramatsu
2020-07-14 11:23 ` [PATCH v3 0/7] riscv: Add k/uprobe supported Masami Hiramatsu
2020-07-15 6:45 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJF2gTSMUnHfv3GLj_TGT2dJkKq2zbEsnbPKREiq5i6PPjyTBg@mail.gmail.com \
--to=guoren@kernel.org \
--cc=anup@brainfault.org \
--cc=bjorn.topel@gmail.com \
--cc=greentime.hu@sifive.com \
--cc=guoren@linux.alibaba.com \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=me@packi.ch \
--cc=mhiramat@kernel.org \
--cc=oleg@redhat.com \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=penberg@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).