From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97028C04FF3 for ; Mon, 24 May 2021 12:01:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F72261360 for ; Mon, 24 May 2021 12:01:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232553AbhEXMDV (ORCPT ); Mon, 24 May 2021 08:03:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:49304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232844AbhEXMC7 (ORCPT ); Mon, 24 May 2021 08:02:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3F0B2613CB; Mon, 24 May 2021 12:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621857691; bh=veNGvYxcLl+vDYUz1SMH3CGwccZ8IWRdI0wIqqjpXHk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nD8gwroafsuYGdv9NfLO0Co93IMx/me0F4AAZKDIR4kw849gUWF0ueVG7PLAVzHEq zul3q6dM9dUQ93Urx1vFQceK7M3j6tH6+N6bMr98eBb6rMOndl+c7Dh5hf88g4yblk Q5d5dTF1w8GnDEklR70EJBmKE80ZA49d2FyeYOOZnUgJP/MgVzoJqSp6l++emo3Ftd 9urpVUBIYqyaSzEQ/+/5T0kOmIi9Iou86kq+VsyhNwQUtA+/dXmVzzDRg00f623Ypk tTvCTu/v3jHt7kYXvnz1aukazjAxtGZKYMA0znBQasdoA5LvhqXEAyQ46zx9ASMX16 8hVMtlTLi1iDw== Received: by mail-lf1-f49.google.com with SMTP id j6so37622316lfr.11; Mon, 24 May 2021 05:01:31 -0700 (PDT) X-Gm-Message-State: AOAM530XLJhleg5ZWgnLUQDgHO9JppiqL4aeCAzZs24gyN32px9Vgo4y JDM+mt/nZVlHJX0wLtz/Q6hJP5CuYygOBXDFtWs= X-Google-Smtp-Source: ABdhPJx/oJ+jz4mGUBNUVDukdZUBydqmcR8FyJX8ZFV9ulMABT6jX8AjToYzvFvtvNgaeYZh3zITll0SsnnwsObfXs4= X-Received: by 2002:a05:6512:36c5:: with SMTP id e5mr10330380lfs.41.1621857689496; Mon, 24 May 2021 05:01:29 -0700 (PDT) MIME-Version: 1.0 References: <1621839068-31738-1-git-send-email-guoren@kernel.org> In-Reply-To: From: Guo Ren Date: Mon, 24 May 2021 20:01:18 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] riscv: Fixup _PAGE_GLOBAL in _PAGE_KERNEL To: Anup Patel Cc: Anup Patel , Palmer Dabbelt , Arnd Bergmann , linux-riscv , "linux-kernel@vger.kernel.org List" , linux-arch , linux-sunxi@lists.linux.dev, Guo Ren Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 24, 2021 at 6:42 PM Anup Patel wrote: > > On Mon, May 24, 2021 at 12:22 PM wrote: > > > > From: Guo Ren > > > > Kernel virtual address translation should avoid care asid or it'll > > cause more TLB-miss and TLB-refill. Because the current asid in satp > > belongs to the current process, but the target kernel va TLB entry's > > asid still belongs to the previous process. > > > > Signed-off-by: Guo Ren > > Cc: Anup Patel > > Cc: Palmer Dabbelt > > --- > > arch/riscv/include/asm/pgtable.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h > > index 78f2323..017da15 100644 > > --- a/arch/riscv/include/asm/pgtable.h > > +++ b/arch/riscv/include/asm/pgtable.h > > @@ -135,6 +135,7 @@ > > | _PAGE_PRESENT \ > > | _PAGE_ACCESSED \ > > | _PAGE_DIRTY \ > > + | _PAGE_GLOBAL \ > > | _PAGE_CACHE) > > It seems this patch is not based on the upstream kernel. The > _PAGE_CACHE seems to be from your other patch series. > > Please rebase these patches on the latest upstream kernel without > dependency on any other patch series. Yes, it based on DMA_COHERENT. I'll rebase in PATCH V2, thx. > > Regards, > Anup > > > > > #define PAGE_KERNEL __pgprot(_PAGE_KERNEL) > > -- > > 2.7.4 > > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/