From: Maxim Uvarov <muvarov@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] dp83867: fix speed 10 in sgmii mode
Date: Thu, 6 Dec 2018 21:27:24 +0300 [thread overview]
Message-ID: <CAJGZr0+fJR1uF8H=sH6FgHxt6xP1cc=FHdGpbqPjqJOuZZ8P8Q@mail.gmail.com> (raw)
In-Reply-To: <20181025230611.GE6276@lunn.ch>
пт, 26 окт. 2018 г. в 02:06, Andrew Lunn <andrew@lunn.ch>:
>
> On Thu, Oct 25, 2018 at 02:05:30PM +0300, Max Uvarov wrote:
>
> Hi Max
>
> > For support 10Mps sped in SGMII mode DP83867_10M_SGMII_RATE_ADAPT bit
>
> speed.
>
> > of DP83867_10M_SGMII_CFG register has to be cleared by software.
> > That does not affect speeds 100 and 1000 so can be done on init.
>
> It would be good to add a Fixes: tag. Has this always been broken?
>
I somehow skipped this reply. I guess that was always broken. More
likely 10M is not the speed what people use nowadays. But anyway it
will be great to fix anyway.
Max.
> Thanks
> Andrew
prev parent reply other threads:[~2018-12-06 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 11:05 [PATCH] dp83867: fix speed 10 in sgmii mode Max Uvarov
2018-10-25 23:06 ` Andrew Lunn
2018-12-06 18:27 ` Maxim Uvarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJGZr0+fJR1uF8H=sH6FgHxt6xP1cc=FHdGpbqPjqJOuZZ8P8Q@mail.gmail.com' \
--to=muvarov@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).