From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB510C433FE for ; Mon, 4 Oct 2021 18:27:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0FCB61354 for ; Mon, 4 Oct 2021 18:27:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238531AbhJDS27 (ORCPT ); Mon, 4 Oct 2021 14:28:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238408AbhJDS26 (ORCPT ); Mon, 4 Oct 2021 14:28:58 -0400 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D321EC061745 for ; Mon, 4 Oct 2021 11:27:08 -0700 (PDT) Received: by mail-yb1-xb34.google.com with SMTP id h2so39762017ybi.13 for ; Mon, 04 Oct 2021 11:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PIqLRUwkpWrhqoIb+2LbHIi6YwYZzYCnePRyYQW7lLY=; b=gjvD3+vx4+r4kREI+kJyLRqAt3T9ueCkkwyrIGXw4kVjsxk4B+g3/MppZhl7N6wTiV PMJqtTnyCh8HPiYVaClZKX6vsiy/6Hky+sKMa3Lv0KbQMju9xs4Np2wLdKgAB0JjT9Od WKQmaL+SK4LQ59q2qi8GLJ4pEsOTqRJWOl1nQNfc6qULxZIsXFlxrSF4fWxTsGlbaevw 2YN7Xw8DA2tlSfBVpAcffPslrlDJrVUOjvu3UqCLjaEuFPaWwtlUYBZRaMkFjY1QzZ/Z uDOdzZ5anwcBpaqRWOz2jV0W6w/UdOifflY5/OMNNvn9JP/fumSBYvDtWLn74afG0khE 2vwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PIqLRUwkpWrhqoIb+2LbHIi6YwYZzYCnePRyYQW7lLY=; b=l6DcOBEhmW0u1jThJe6zjPolrQcBzGi9jv+WM2lWNwmq3WBmLojHdrIval4ZzMldqk z+Ir02wYWuGZVPgvtnO6VbfaeynXM/2PZuo0z9XzQeHX9WU21R0aP7oZAWBZNFMlEtd+ 0LlXI5MjjgLXOhjWT3HYvVmmFk6mLsJwJqjpOz05YSxd3Yc2efVW7QCYoKCR6yfnERn1 k0Cs57PbpNwTiRCcxR1ZZ8ySwg7PFE8MnNV/38PYYC86HnR43nCYFDOQaRlxoU1jcpFx 8zgvD5areANoazzsJ1shX7EYFatQbtE8ySNW5EHm9e+ARuzBE/2FdS5oOOCuXQsc8PWa PE1Q== X-Gm-Message-State: AOAM532WfYJ/9UcqBjnTRKfaA50+Syd/rATiTkblyJdAeoZeomcQj8Xh ZXymMp+Ohjb34o/Utlic/PAValjogcbRESgWJw7rew== X-Google-Smtp-Source: ABdhPJwQO8pJHFNb8p9v0Uv+zTJOyZYyUBFOwoiGCzuPT59UynGevvRHp+VVKupk5VUaX29Kw8b7Zy4woqEdE6YhWDI= X-Received: by 2002:a5b:283:: with SMTP id x3mr16689301ybl.439.1633372027973; Mon, 04 Oct 2021 11:27:07 -0700 (PDT) MIME-Version: 1.0 References: <20210914223114.435273-1-rananta@google.com> <20210914223114.435273-13-rananta@google.com> In-Reply-To: From: Raghavendra Rao Ananta Date: Mon, 4 Oct 2021 11:26:57 -0700 Message-ID: Subject: Re: [PATCH v7 12/15] KVM: arm64: selftests: Add basic GICv3 support To: Zenghui Yu Cc: Paolo Bonzini , Marc Zyngier , Andrew Jones , James Morse , Alexandru Elisei , Suzuki K Poulose , kvm@vger.kernel.org, Catalin Marinas , Peter Shier , linux-kernel@vger.kernel.org, Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 30, 2021 at 1:06 AM Zenghui Yu wrote: > > On 2021/9/15 6:31, Raghavendra Rao Ananta wrote: > > +static inline void *gicr_base_gpa_cpu(void *redist_base, uint32_t cpu) > > +{ > > + /* Align all the redistributors sequentially */ > > + return redist_base + cpu * SZ_64K * 2; > > +} > > + > > +static void gicv3_cpu_init(unsigned int cpu, void *redist_base) > > +{ > > + void *sgi_base; > > + unsigned int i; > > + void *redist_base_cpu; > > + > > + GUEST_ASSERT(cpu < gicv3_data.nr_cpus); > > + > > + redist_base_cpu = gicr_base_gpa_cpu(redist_base, cpu); > > This is not 'gpa' and I'd rather open-code it directly as there's > just a single caller. > > Zenghui Thanks for catching this. I agree that mentioning 'gpa' oddballs this function, since it's called from a guest's point of view. If there are any other major changes in the series, I'll try to change this as well. Else, I will try to raise a separate patch to resolve this. Regards, Raghavendra