From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48EF6C433DB for ; Wed, 10 Mar 2021 04:44:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0311164FEE for ; Wed, 10 Mar 2021 04:44:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232172AbhCJEkV (ORCPT ); Tue, 9 Mar 2021 23:40:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232031AbhCJEjy (ORCPT ); Tue, 9 Mar 2021 23:39:54 -0500 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2BEDC06174A for ; Tue, 9 Mar 2021 20:39:53 -0800 (PST) Received: by mail-il1-x12d.google.com with SMTP id f10so14327827ilq.5 for ; Tue, 09 Mar 2021 20:39:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kMxMSisdcB4iYz8wEr7jHpP6C1gdaDzmlJgzQ9auShs=; b=eGLdAQTEQTANhdedq17FapcRChntTlpJItXkzH9Jrjguv0hdtaFJ6sCepMOtMihcK1 NB6QsuTyjKmlTEYKVzV2SW+3FGXCWpZwBUZhfmE3e8oM8j1yfKrQ/OACN9ne22aAUASH hcFphgZ0XY+BDjdQvlK2frqT8/TS8bMD6wj4x/T5DaiBwlMRVqNERubtwk8230lNjZVS 7iBv3+wHMZ3LTjrGX6cWmX2sLYzlNU+KkgBJyOygTBGtT7SE36v6N6wFfrqYq6YyGFZ4 xlyJLcRYxyq8yy6LWlOtf6TbE3JHdHUOGV2nyk9FHNr3jwFHC4Yoie30x3z/Mfb+B1rF Y7KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kMxMSisdcB4iYz8wEr7jHpP6C1gdaDzmlJgzQ9auShs=; b=X+cZ5dNhN2r7T35aRSj9A74MWQt32Ae3cAW4nBgClYECdjFWDr/Ch1CBuLsQaf0U+6 Ga2K8FJ64p9XWho+BQUYwvLusGDm6LVUgLKonFL58k+R4Bx6Z4uWEYJweUUANHVjRlMd cob6DA00kZrSBVCVi6BdL+HDyGPySgP/cZ5rRIAcmzFjp79aPNRwqbb+j3pzZmUbjDh/ vyy7a7RLMC0tFZdAuKlD9NGCB6a/i1u3N0e5Qmm+7e/VHB8WeNLOb+sJm2mBYXsuqlOL wUUYdMlYbG/fSQoyrz2jesijNwkpkJU6sXyPAk/CFZTzIUGm7ghfVfxWiVQ8OrJjXJNL zSKQ== X-Gm-Message-State: AOAM531elyeVSydjRJFG/hmy8bF0ksyhuD6u6mDc3zFqG0t6skhA0hxV 5iamaAQsUBAkGQm0ID4xXEfGuC0/YC/GhrG+i2UiTw== X-Google-Smtp-Source: ABdhPJzkpjybl/vKBkOtlpw4P7Zz3pv9jti8Pynm2Bp5lzLC85cdEwxz9nWWMDj+P6oiWidL/vwGwLGqn1rvRtQbPLE= X-Received: by 2002:a92:ce4c:: with SMTP id a12mr1333640ilr.258.1615351193004; Tue, 09 Mar 2021 20:39:53 -0800 (PST) MIME-Version: 1.0 References: <20210310141606.75e990d2@canb.auug.org.au> In-Reply-To: <20210310141606.75e990d2@canb.auug.org.au> From: Axel Rasmussen Date: Tue, 9 Mar 2021 20:39:16 -0800 Message-ID: Subject: Re: linux-next: build failure after merge of the akpm-current tree To: Stephen Rothwell Cc: Andrew Morton , Linux Kernel Mailing List , Linux Next Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 9, 2021 at 7:16 PM Stephen Rothwell wrote: > > Hi all, > > After merging the akpm-current tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: Hi Stephen, Sorry about the failure! Indeed, I had guarded this in the header, but not in the .c file. I sent a v2.5 of the patch earlier today which fixes the issue, but it hasn't made its way to Andrew's tree just yet. I'll CC you on that thread as well, as an FYI. Reverting the patches is also a fine workaround. Next time, I'll test with more config permutations. :) > > mm/shmem.c:2365:12: warning: 'enum mcopy_atomic_mode' declared inside parameter list will not be visible outside of this definition or declaration > 2365 | enum mcopy_atomic_mode mode, struct page **pagep) > | ^~~~~~~~~~~~~~~~~ > mm/shmem.c:2365:30: error: parameter 6 ('mode') has incomplete type > 2365 | enum mcopy_atomic_mode mode, struct page **pagep) > | ~~~~~~~~~~~~~~~~~~~~~~~^~~~ > mm/shmem.c:2362:5: error: function declaration isn't a prototype [-Werror=strict-prototypes] > 2362 | int shmem_mcopy_atomic_pte(struct mm_struct *dst_mm, pmd_t *dst_pmd, > | ^~~~~~~~~~~~~~~~~~~~~~ > mm/shmem.c: In function 'shmem_mcopy_atomic_pte': > mm/shmem.c:2367:30: error: 'MCOPY_ATOMIC_CONTINUE' undeclared (first use in this function) > 2367 | bool is_continue = (mode == MCOPY_ATOMIC_CONTINUE); > | ^~~~~~~~~~~~~~~~~~~~~ > mm/shmem.c:2367:30: note: each undeclared identifier is reported only once for each function it appears in > mm/shmem.c:2394:15: error: 'MCOPY_ATOMIC_NORMAL' undeclared (first use in this function) > 2394 | if (mode == MCOPY_ATOMIC_NORMAL) { /* mcopy_atomic */ > | ^~~~~~~~~~~~~~~~~~~ > > Caused by commit > > 3407bec05d6d ("userfaultfd: support minor fault handling for shmem") > > # CONFIG_USERFAULTFD is not set > > I have reverted that commit (and the following 4 as well). > -- > Cheers, > Stephen Rothwell