From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Tejun Heo <tj@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Hans de Goede <hdegoede@redhat.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andi Shyti <andi@etezian.org>, Mark Brown <broonie@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org,
linux-usb@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Jaehoon Chung <jh80.chung@samsung.com>
Subject: Re: [RFC 06/10] thermal: samsung: Remove support for Exynos5440
Date: Thu, 26 Apr 2018 09:59:15 +0200 [thread overview]
Message-ID: <CAJKOXPc4oDAFThxVszOrCr+yEaK85W3AeYTcLFyGm0-6TLyZyw@mail.gmail.com> (raw)
In-Reply-To: <5AE12E4A.90907@samsung.com>
On Thu, Apr 26, 2018 at 3:41 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi Krzysztof,
>
> On 2018년 04월 25일 05:32, Krzysztof Kozlowski wrote:
>> The Exynos5440 is not actively developed, there are no development
>> boards available and probably there are no real products with it.
>> Remove wide-tree support for Exynos5440.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>> .../devicetree/bindings/thermal/exynos-thermal.txt | 14 +-
>> drivers/thermal/samsung/exynos_tmu.c | 155 +--------------------
>> drivers/thermal/samsung/exynos_tmu.h | 1 -
>> 3 files changed, 4 insertions(+), 166 deletions(-)
>
>
> After applied this patch, I tested the build and found out
> 'exynos5440' keyword. There is one comment including 'exynos5440' as following:
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index f92f470bce21..cb525228cfe1 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -943,7 +943,7 @@ static void exynos4210_tmu_clear_irqs(struct exynos_tmu_data *data)
> * Exynos3250, Exynos4412, Exynos5250 and Exynos5260 incorrectly
> * states that INTCLEAR register has a different placing of bits
> * responsible for FALL IRQs than INTSTAT register. Exynos5420
> - * and Exynos5440 documentation is correct (Exynos4210 doesn't
> + * documentation is correct (Exynos4210 doesn't
> * support FALL IRQs at all).
> */
> writel(val_irq, data->base + tmu_intclear);
>
> After removing it, looks good to me.
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks, I left this comment intentionally as it has some meaning even
when Exynos5440 is not supported.
Best regards,
Krzysztof
next prev parent reply other threads:[~2018-04-26 7:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 20:32 [RFC 00/10] ARM: Remove support for Exynos5440 Krzysztof Kozlowski
2018-04-24 20:32 ` [RFC 01/10] ARM: dts: exynos: Remove Exynos5440 Krzysztof Kozlowski
2018-04-26 4:31 ` andi
2018-05-01 14:07 ` Rob Herring
2018-05-02 17:07 ` Krzysztof Kozlowski
2018-04-24 20:32 ` [RFC 02/10] ata: ahci-platform: Remove support for Exynos5440 Krzysztof Kozlowski
2018-05-01 14:08 ` Rob Herring
2018-04-24 20:32 ` [RFC 03/10] cpufreq: exynos: " Krzysztof Kozlowski
2018-04-25 2:48 ` Viresh Kumar
2018-04-26 1:05 ` Chanwoo Choi
2018-05-01 14:08 ` Rob Herring
2018-04-24 20:32 ` [RFC 04/10] clk: samsung: " Krzysztof Kozlowski
2018-04-25 12:49 ` Sylwester Nawrocki
2018-04-26 0:58 ` Chanwoo Choi
2018-05-01 22:01 ` Stephen Boyd
2018-04-24 20:32 ` [RFC 05/10] i2c: s3c2410: " Krzysztof Kozlowski
2018-04-25 12:56 ` Sylwester Nawrocki
2018-04-26 4:33 ` andi
2018-04-28 12:44 ` Wolfram Sang
2018-04-24 20:32 ` [RFC 06/10] thermal: samsung: " Krzysztof Kozlowski
2018-04-25 10:42 ` Bartlomiej Zolnierkiewicz
2018-04-25 13:18 ` Bartlomiej Zolnierkiewicz
[not found] ` <CGME20180426112113eucas1p1b5bf6f093442154e29f5541b4aba6b00@eucas1p1.samsung.com>
2018-04-26 11:21 ` [PATCH] " Bartlomiej Zolnierkiewicz
2018-05-01 14:45 ` Rob Herring
2018-04-26 1:41 ` [RFC 06/10] " Chanwoo Choi
2018-04-26 7:59 ` Krzysztof Kozlowski [this message]
2018-04-24 20:32 ` [RFC 07/10] pinctrl: " Krzysztof Kozlowski
2018-04-26 1:15 ` Chanwoo Choi
2018-05-02 17:09 ` Krzysztof Kozlowski
2018-04-24 20:32 ` [RFC 08/10] spi: s3c64xx: " Krzysztof Kozlowski
2018-04-25 12:49 ` Sylwester Nawrocki
2018-04-25 12:55 ` Krzysztof Kozlowski
2018-04-26 4:35 ` andi
2018-04-24 20:32 ` [RFC 09/10] usb: host: exynos: " Krzysztof Kozlowski
2018-04-25 12:04 ` Greg Kroah-Hartman
2018-04-24 20:32 ` [RFC 10/10] ARM: " Krzysztof Kozlowski
2018-05-02 17:07 ` Krzysztof Kozlowski
2018-04-24 20:50 ` [RFC 00/10] ARM: " Arnd Bergmann
2018-04-24 20:56 ` Krzysztof Kozlowski
2018-04-24 21:12 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPc4oDAFThxVszOrCr+yEaK85W3AeYTcLFyGm0-6TLyZyw@mail.gmail.com \
--to=krzk@kernel.org \
--cc=andi@etezian.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jh80.chung@samsung.com \
--cc=kgene@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=olof@lixom.net \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
--cc=tomasz.figa@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).