From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688F2C0650F for ; Thu, 8 Aug 2019 12:31:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C82E2189E for ; Thu, 8 Aug 2019 12:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565267517; bh=bdQZvsSQ32pIcK00dvHnvYCuayYBNzzTq0JqfKXAAnA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ze/IaDY3mtmjxJFSeNx1F2GJ4TUZhxt6mBduRhlClJ0zAXJFhlju56ZEbWa9XB8pP JYLD+WOmBbxq9hukUBzkEleWZ/WJKZOU6cSYYUoCd+wnWb7Oxwb/bvuHwYnPuDG4a+ AvPsJff+vDxgRKYcbABHFNxu8502Q7KN2dYlKhzw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403898AbfHHMb4 (ORCPT ); Thu, 8 Aug 2019 08:31:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:45704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403878AbfHHMbx (ORCPT ); Thu, 8 Aug 2019 08:31:53 -0400 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3667F218A4; Thu, 8 Aug 2019 12:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565267512; bh=bdQZvsSQ32pIcK00dvHnvYCuayYBNzzTq0JqfKXAAnA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=opj1qQf9iEv45GohNPIZzhCfVIZu1ZKpRtt66TnyPL0lOzTJk5eitdVMhBoy+g0Hf UVInrjj0SFWueYHRvOSGyc2Fpz0WX4Dk4DE0AzIZES1sOm0BnypToJNP5f4pPpc22P wQUfdU1+dQ5DAUF2r3Ky0lG/+/V7pVl8LsPRJRnY= Received: by mail-lj1-f181.google.com with SMTP id p17so88755682ljg.1; Thu, 08 Aug 2019 05:31:52 -0700 (PDT) X-Gm-Message-State: APjAAAUT5PPbj95rvcI9AaKvULcLH5UuERGUxkAPpnVMe3cRJG1kPyFF WmS/pyH828ZjbTD7Dn0OwwGFNTNcj/dhTaIaMmA= X-Google-Smtp-Source: APXvYqzE6I+ay+3PmHe0pYVJmR3CgZhxE3A6RP3FlUDg7MjWb3h3zbv3W0JwnvdTTIFomcUI0MjdcuE87ZGWhiIDMH0= X-Received: by 2002:a2e:3008:: with SMTP id w8mr8290719ljw.13.1565267510378; Thu, 08 Aug 2019 05:31:50 -0700 (PDT) MIME-Version: 1.0 References: <20190718143044.25066-1-s.nawrocki@samsung.com> <20190718143044.25066-4-s.nawrocki@samsung.com> In-Reply-To: From: Krzysztof Kozlowski Date: Thu, 8 Aug 2019 14:31:39 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/9] soc: samsung: Add Exynos Adaptive Supply Voltage driver To: Sylwester Nawrocki Cc: robh+dt@kernel.org, vireshk@kernel.org, devicetree@vger.kernel.org, kgene@kernel.org, pankaj.dubey@samsung.com, "linux-samsung-soc@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" , linux-pm@vger.kernel.org, =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= , Marek Szyprowski Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Aug 2019 at 14:07, Sylwester Nawrocki wrote: > >> +static unsigned int exynos5422_asv_parse_table(struct exynos_asv *asv, > >> + unsigned int pkg_id) > >> +{ > >> + return (pkg_id >> EXYNOS5422_TABLE_OFFSET) & EXYNOS5422_TABLE_MASK; > >> +} > >> + > >> +static bool exynos5422_asv_parse_bin2(struct exynos_asv *asv, > >> + unsigned int pkg_id) > >> +{ > >> + return (pkg_id >> EXYNOS5422_BIN2_OFFSET) & EXYNOS5422_BIN2_MASK; > > > > return !!() for converting to boolean. > > I'm not convinced it is needed, the return type of the function is bool > and value of the expression will be implicitly converted to that type. > Is there any compiler warning related to that? Yeah, but bool is int so there will be no implicit conversion... I guess it is a convention. In theory !! is the proper conversion to bool but if bool==int then it's essentially conversion to 1. I am not sure what's the benefit, maybe for some wrong code which would do comparisons on result like if (exynos5422_asv_parse_bin2() == TRUE)... Best regards, Krzysztof