From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751320AbcFAUG1 (ORCPT ); Wed, 1 Jun 2016 16:06:27 -0400 Received: from mail.kernel.org ([198.145.29.136]:50087 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbcFAUGZ (ORCPT ); Wed, 1 Jun 2016 16:06:25 -0400 MIME-Version: 1.0 In-Reply-To: References: <1464429273-23457-1-git-send-email-krzk@kernel.org> <1464429273-23457-14-git-send-email-krzk@kernel.org> Date: Wed, 1 Jun 2016 22:06:21 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 From: Krzysztof Kozlowski To: Kevin Hilman Cc: Kukjin Kim , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , linux-arm-kernel , linux-samsung-soc@vger.kernel.org, devicetree , lkml , linux-clk@vger.kernel.org, Javier Martinez Canillas , Rob Herring Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 1, 2016 at 9:57 PM, Kevin Hilman wrote: > Hi Krzysztof, > > On Sat, May 28, 2016 at 2:54 AM, Krzysztof Kozlowski wrote: >> Just like other Exynos5 family SoCs, this one has four UARTs. Configure >> clocks for UART3 and enable it. >> >> Signed-off-by: Krzysztof Kozlowski >> Reviewed-by: Javier Martinez Canillas > > This patch landed in linux-next[1] and kernelci.org found a boot > regression on the exynos5410-odroidxu[2], where it looks like it's > faulting in clk_prepare(). Bisecting pointed to this patch. I added > "status = disabled" back into the DTS on top of next-20160601[3] and > verified my odroid-XU to be booting fine again. Hi, Thanks for report. Indeed the patch brings up to the light an issue in serial driver. Fixed here: https://lkml.org/lkml/2016/5/31/570 I left the commit in my tree as it is correct (strictly speaking). Sorry for any trouble it makes. Best regards, Krzysztof