From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 014DDC2D0A3 for ; Wed, 4 Nov 2020 08:12:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81F1422384 for ; Wed, 4 Nov 2020 08:12:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604477568; bh=zMzZrWx2IXhl/Cyh/m1Iiz3JMtBjvBovOMMHg9VdGUM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=NLF6/8NeinHxkW9400mNCnwDrJ5UBmXHlfRuG1EY3tXvOG0FGV1xT8JkocRqwXPC4 VLnFk/Gj62uSF1VX54I6RjJ7RjxloRf3B/9P5plG09uDi9X6+onS7QRJ6NbCcdb+Li 278kUhPKXOno30UQ4IUseKvw+tgC7RIorlZFz9LI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727665AbgKDIMr (ORCPT ); Wed, 4 Nov 2020 03:12:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:42638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725896AbgKDIMr (ORCPT ); Wed, 4 Nov 2020 03:12:47 -0500 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3953C223C7 for ; Wed, 4 Nov 2020 08:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604477566; bh=zMzZrWx2IXhl/Cyh/m1Iiz3JMtBjvBovOMMHg9VdGUM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=f+yjZpkkayKaAuRxpZew9acwh9iE4gUEpEZ/9+vKpJw19d8ekKNObsmrWTDgHQN5F fzKtrh1XSE0tjXQNhcUBQCmm4q+9PKMLyulodeubpyyvGa7X2D0HQRiLGYH8OamdwD zULQ+blviN48gHh9+gDay2Ay+rZV/FI+qsPRlaI4= Received: by mail-ed1-f42.google.com with SMTP id b9so11294625edu.10 for ; Wed, 04 Nov 2020 00:12:46 -0800 (PST) X-Gm-Message-State: AOAM533I5NgqAxeccWxAC0dSfOS9tPCSbvzFyfB3KZvsfdBEZMTn8ez6 euTMkgIu1dbYBUqyhHpyN3ftyttAUdBSnX6HRDw= X-Google-Smtp-Source: ABdhPJzLcmOxaq6t3mAz7sOoOclvQWzmvxE0qmw9sqC3M71XjkyDKc49lYC5BnGwHy3sMCJPJmJL8V8E2nkLTEyfUR0= X-Received: by 2002:a50:8b65:: with SMTP id l92mr26319773edl.132.1604477564706; Wed, 04 Nov 2020 00:12:44 -0800 (PST) MIME-Version: 1.0 References: <20201104030645.12931-1-alice.guo@nxp.com> <20201104030645.12931-2-alice.guo@nxp.com> In-Reply-To: From: Krzysztof Kozlowski Date: Wed, 4 Nov 2020 09:12:32 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 1/4] LF-2571-1: dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID To: Peng Fan Cc: Alice Guo , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Nov 2020 at 09:04, Peng Fan wrote: > > > +ed=0 > > > + > > > +title: NXP i.MX8M Platforms Device Tree Bindings > > > > This is not a title for these bindings. Please describe the bindings for this > > device. Based on description, this might could go to bindings/nvmem > > directory. > > It might be misleading here. I think the bindings is for SoC, just like > "arm,realview-eb-soc" in > Documentation/devicetree/bindings/arm/arm,realview.yaml > > Reading the patch, it is to convert soc-imx8m.c to platform driver, > so need to add a compatible string for the soc device, > I think Documentation/devicetree/bindings/arm/fsl.yaml should be > a better place. Thanks for clarification. Putting it with arm/fsl.yaml looks reasonable. Best regards, Krzysztof