From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2D5FC433E7 for ; Mon, 19 Oct 2020 17:06:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D11622314 for ; Mon, 19 Oct 2020 17:06:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603127179; bh=0O1fhJYNZelW5IlOs5LX842TXGsnkAfhUi+vSpLlLEU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Rf0liJ2oAhlyyb5Ld2+CF4xJ67hx9v9BYvoIXg6HR3bfG8csOsVaVaR2ifyIpSgw0 N6sMzxxyWcAl35+SKA9/Tmq42F/UciHop3UzoWPpnM6I7QV10mXVJNPtiOv1734yI/ dp6krF/rN+YWFqC9bHvGp77JhzN+gmGx7PdpJJeU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730945AbgJSRGS (ORCPT ); Mon, 19 Oct 2020 13:06:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:37010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730552AbgJSRGS (ORCPT ); Mon, 19 Oct 2020 13:06:18 -0400 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 37E0222365; Mon, 19 Oct 2020 17:06:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603127177; bh=0O1fhJYNZelW5IlOs5LX842TXGsnkAfhUi+vSpLlLEU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=v7lhCyYxO2IAejY4XtXtiwc4whRS6uQV1lYeCuroS/EEctzWODXNTnUTtNguaI+mz JbWhhXSNrFIo3ymIIop1a8UYKkIN80pu/AbUgoDfn0TrQEwAgJiZiMmZOVFv5uZV1e 3ecpgzkwkTa637cz4jGMWy+t9u9rBLM8U1xfHTkk= Received: by mail-ed1-f50.google.com with SMTP id p13so57291edi.7; Mon, 19 Oct 2020 10:06:17 -0700 (PDT) X-Gm-Message-State: AOAM530duXQSfgZu3sgzjV/kYk0uzjAZz9cJZW2cZ2Dwol67qg6VIXCa jgUkcvFYz2O7Sk7dUdcdxG3D9hvEIeb4fHJnoaM= X-Google-Smtp-Source: ABdhPJyxGPC/GKoJUw/Nkd9Pik+1J1JxIOUpJXCguSpUW1ESiyaEuX3B+znG3C6aqVitqC96v1zxV6VeCvuS9nQxPp8= X-Received: by 2002:aa7:cf17:: with SMTP id a23mr796273edy.298.1603127175197; Mon, 19 Oct 2020 10:06:15 -0700 (PDT) MIME-Version: 1.0 References: <20201008212706.870115-1-aford173@gmail.com> <20201008212706.870115-2-aford173@gmail.com> <20201012170016.GA5369@kozik-lap> In-Reply-To: From: Krzysztof Kozlowski Date: Mon, 19 Oct 2020 19:06:03 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] arm64: dts: imx8mm: Add node for SPDIF To: Fabio Estevam Cc: Adam Ford , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Adam Ford-BE , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Catalin Marinas , Will Deacon , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Oct 2020 at 18:56, Fabio Estevam wrote: > > Hi Krzysztof, > > On Mon, Oct 12, 2020 at 2:00 PM Krzysztof Kozlowski wrote: > > > > + spdif1: spdif@30090000 { > > > + compatible = "fsl,imx8mm-spdif", "fsl,imx35-spdif"; > > > > This does not pass the dtschema validation, so only "fsl,imx35-spdif". > > Shouldn't the dt schema validation be changed then to accept this format? Depends. If a given compatible is in the schema, then the answer is: rather not. The DTS conform to schema, not the otherwise. When dtschema is sent this is the ABI to which the kernel should conform. User-space or other SW (e.g. U-Boot) could depend on it. Of course there are exceptions... If the compatible is not in the schema, then of course it could be added if there is a need. In this case, device is simply compatible with "fsl,imx35-spdif" so there is no real need to change the schema. Just use the existing compatible. Look at one funny example in iMX: drivers/pwm/pwm-imx27.c. Someone created multiple compatibles but does not use them at all, because the hardware looks exactly the same. Therefore driver implements only one compatible because entire HW is compatible with fsl,imx27-pwm. In such clear case, why adding many compatibles? It's just a churn. Best regards, Krzysztof