From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB898C433E7 for ; Tue, 1 Sep 2020 08:17:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 881DD206CD for ; Tue, 1 Sep 2020 08:17:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598948267; bh=rdISuijoV73lvWE9OMZrJ/NR+PxcP29W+Ynjt7uSUDY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=M9Ir3YxY/KLL0tHjJOvviOsW+ar9AO/5tcqoTzkFwwc1RwCBKCqV1I8mrjPr9TKtN BkxGWi9Eee+QZ5d+V3mDigJzcWPVW3qBYn6GebU3U1HT2+5vCViW3HNpVseyiSpAqB wY+7KiIm3FN925qRnGG3T+s/888sJFYwwBQ4T99Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726512AbgIAIRq (ORCPT ); Tue, 1 Sep 2020 04:17:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:42592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725949AbgIAIRn (ORCPT ); Tue, 1 Sep 2020 04:17:43 -0400 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9A8E206CD; Tue, 1 Sep 2020 08:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598948263; bh=rdISuijoV73lvWE9OMZrJ/NR+PxcP29W+Ynjt7uSUDY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=fdDxtMmbaV42htBPIYMNGIp0bvMTvIcIg71AcO6nFg2Jay3ZIka/yM0pa7Bz2PEkx YBcLGE6KsHctQnEWAPdnP20aUFWmbIeqorKsyTvOt02pUrCiMzt3YQqg5ODbc7EgJZ rJGsunFDmnFCYYD8EL3m0BIJ2bxt+eIv3v6TD0IY= Received: by mail-ej1-f50.google.com with SMTP id z22so384400ejl.7; Tue, 01 Sep 2020 01:17:42 -0700 (PDT) X-Gm-Message-State: AOAM533GVnVAt4DWvTF8oOUccLv5EID+hu5LvDEMiXBnp650CZWd/MqJ +Wv/Ge7jnBG1rjRoqZpr0vzZ8x73Xf6nU3AjmVU= X-Google-Smtp-Source: ABdhPJyzrmg/Kw1aCmZCJ4oQuuaPApfCpNq6koAmkTtNb2EOzNn5NbjqUfBMBNbWpRwdhvxDjmQgZvkdwnlWEh3r6MY= X-Received: by 2002:a17:906:8401:: with SMTP id n1mr431626ejx.215.1598948261432; Tue, 01 Sep 2020 01:17:41 -0700 (PDT) MIME-Version: 1.0 References: <20200901075417.22481-1-krzk@kernel.org> <20200901075417.22481-12-krzk@kernel.org> <800d8fa8-7fd4-6221-f8be-ef422e5642d9@samsung.com> In-Reply-To: <800d8fa8-7fd4-6221-f8be-ef422e5642d9@samsung.com> From: Krzysztof Kozlowski Date: Tue, 1 Sep 2020 10:17:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/13] ARM: dts: exynos: Silence SATA PHY warning in Exynos5250 Arndale To: Marek Szyprowski Cc: Rob Herring , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Bartlomiej Zolnierkiewicz , Sylwester Nawrocki Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Sep 2020 at 10:13, Marek Szyprowski wrote: > > Hi Krzysztof, > > On 01.09.2020 09:54, Krzysztof Kozlowski wrote: > > The SATA PHY in Exynos5250 SoCs has two interfaces and two device nodes: > > 1. sata-phy@12170000 > > 2. i2c-9/i2c@38 > > > > The first node represents the actual SATA PHY device with phy-cells. > > The second represents additional I2C interface, needed by the driver > > to communicate with the SATA PHY device. It is not a PHY-provider in > > the terms of dtschema so rename it to silence dtbs_check warning: > > > > arch/arm/boot/dts/exynos5250-arndale.dt.yaml: sata-phy@38: '#phy-cells' is a required property > > From schema: lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > arch/arm/boot/dts/exynos5250-arndale.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts > > index f2bcce167b2d..3c401c82905c 100644 > > --- a/arch/arm/boot/dts/exynos5250-arndale.dts > > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts > > @@ -544,7 +544,7 @@ > > samsung,i2c-max-bus-freq = <40000>; > > samsung,i2c-slave-addr = <0x38>; > > > > - sata_phy_i2c: sata-phy@38 { > > + sata_phy_i2c: sata-phy-i2c@38 { > > compatible = "samsung,exynos-sataphy-i2c"; > > reg = <0x38>; > > }; > > I'm not against the rename, but frankly, the above node and all i2c > parameters should be moved to exynos5250.dtsi. This is a SoC internal > things (the same way as hdmiphy in exynos4.dtsi), so the board dts > should only contain information like status = "enabled" for i2c_8 and > hdmi_i2c_phy nodes. No need to duplicate it here and in smdk5250.dts. Good point, the I2C bus used here is an internal part of SoC. I will squash these two changes into a new one. Thanks for the review! Best regards, Krzysztof