From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03ACCC43463 for ; Fri, 18 Sep 2020 08:19:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA8AD21582 for ; Fri, 18 Sep 2020 08:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600417184; bh=BJGVXo9LuBYkG/UJ83GT4URHLbNRNG+Zxm/NJ71KpQM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=j8RUane07fvrZmwtYPTn1rG9g3/xuqiRHGWCXTfQiPvx1tFYXG6IDMFYFhgWOXKsD V0dYp73vkaijI8MvfQr6nOT1LqgbmzjHkzd8uQEg/KSfMqr+7GdLy12MolGgFEO7DF lp7OiFpFj49024f4VOTBx1DRNDhRfyxP/tDNmSTA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726609AbgIRITn (ORCPT ); Fri, 18 Sep 2020 04:19:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:45884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbgIRITm (ORCPT ); Fri, 18 Sep 2020 04:19:42 -0400 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7788121D20; Fri, 18 Sep 2020 08:19:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600417181; bh=BJGVXo9LuBYkG/UJ83GT4URHLbNRNG+Zxm/NJ71KpQM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=EJFz3tnFnXVUibC3YjJ/aDnX9vkiw9iq4EOtKW9AY1UzHJjf1IKzyYfw1N2p1QO8m P6M8ES8lJXTghi6n/cG7hjYZ3GeO1N7Fc/cTU7jR211u/HsFoqwjlmyBMdPFS3JgdU 2ERcli34bBFhjIO+FPo08NLHVYa3E8zGl3lcg3RA= Received: by mail-wr1-f45.google.com with SMTP id t10so4702422wrv.1; Fri, 18 Sep 2020 01:19:41 -0700 (PDT) X-Gm-Message-State: AOAM5316qZap81LiF3C5fHOFDBXKQVafkq/HmSAVfuaWsTE/G+89jpzb FZPaQv6FmMXI3dfhJ+u80SFuLBZHIZ+LyMMUNbE= X-Google-Smtp-Source: ABdhPJxjVFR3dSbIHpxy/vgZ/bWImIgEGLUaIDHRxTPfiF/dL+umHl5OoO3hY+yZN6dZjAPUxX/KLimMiPWxT50m8Xg= X-Received: by 2002:a17:907:724f:: with SMTP id ds15mr33866016ejc.119.1600417177168; Fri, 18 Sep 2020 01:19:37 -0700 (PDT) MIME-Version: 1.0 References: <20200917165301.23100-1-krzk@kernel.org> <20200917165301.23100-10-krzk@kernel.org> <20200917201204.GG3969@pendragon.ideasonboard.com> In-Reply-To: <20200917201204.GG3969@pendragon.ideasonboard.com> From: Krzysztof Kozlowski Date: Fri, 18 Sep 2020 10:19:25 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 09/13] dt-bindings: pinctrl: include common schema in GPIO controllers To: Laurent Pinchart Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , Palmer Dabbelt , Paul Walmsley , Hoan Tran , Serge Semin , Richard Fitzgerald , Lee Jones , Maxime Coquelin , Alexandre Torgue , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Maxime Ripard , Chen-Yu Tsai , Matthias Brugger , Geert Uytterhoeven , Liam Girdwood , Mark Brown , Chris Packham , Anson Huang , Sungbo Eo , Stefan Agner , Srinivas Kandagatla , Magnus Damm , Yash Shah , Paul Kocialkowski , - , Matti Vaittinen , Amelie Delaunay , Cristian Ciocaltea , Paul Cercueil , Andy Teng , Sean Wang , Sricharan R , Chris Brandt , Jaroslav Kysela , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Sep 2020 at 22:12, Laurent Pinchart wrote: > > Hi Krzysztof, > > Thank you for the patch. > > On Thu, Sep 17, 2020 at 06:52:57PM +0200, Krzysztof Kozlowski wrote: > > Include the common GPIO schema in GPIO controllers to be sure all common > > properties are properly validated. > > Shouldn't we delete the properties that are now redundant from these > schemas ? Good point. However not with "additionalPropeties: false". Schema requires all properties to be mentioned. I would need to use "unevaluatedProperties: false" in each file. What is preferred? Best regards, Krzysztof