From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751487AbdK3Hvn (ORCPT ); Thu, 30 Nov 2017 02:51:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:46562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbdK3Hvm (ORCPT ); Thu, 30 Nov 2017 02:51:42 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34BA921997 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=krzk@kernel.org X-Google-Smtp-Source: AGs4zMYiuevBwYF4Ux4044ylqM1aFVJBzFAfx/NDrxtbE/Vc8u5mPx4WgTVl5D7k9h05RtqnpAqkSZapawyzaHZG4Xs= MIME-Version: 1.0 In-Reply-To: <46152007-e599-23eb-6a07-cc5f3ff32c70@samsung.com> References: <20171103165446.15438-1-s.nawrocki@samsung.com> <20171103165446.15438-2-s.nawrocki@samsung.com> <20171127181213.lxtbbiw75wbz2dbz@kozik-lap> <46152007-e599-23eb-6a07-cc5f3ff32c70@samsung.com> From: Krzysztof Kozlowski Date: Thu, 30 Nov 2017 08:51:38 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] ARM: dts: exynos: Switch to dedicated Odroid-XU3 sound card binding To: Marek Szyprowski Cc: Sylwester Nawrocki , kgene@kernel.org, mihailescu2m@gmail.com, =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2017 at 8:30 AM, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2017-11-29 18:55, Krzysztof Kozlowski wrote: >> >> On Mon, Nov 27, 2017 at 7:12 PM, Krzysztof Kozlowski >> wrote: >>> >>> On Fri, Nov 03, 2017 at 05:54:45PM +0100, Sylwester Nawrocki wrote: >>>> >>>> The new sound card DT binding is used for Odroid XU3 in order >>>> to properly support the HDMI audio path. >>>> Clocks configuration is changed so the I2S controller is now the bit >>>> and the frame clock master with EPLL as the root clock source. >>>> >>>> Signed-off-by: Sylwester Nawrocki >>>> --- >>>> arch/arm/boot/dts/exynos4.dtsi | 1 + >>>> arch/arm/boot/dts/exynos5420.dtsi | 1 + >>>> arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi | 60 >>>> ++++++++++++++--------- >>>> 3 files changed, 40 insertions(+), 22 deletions(-) >>>> >> >> Unfortunately this patch causes the audio card to disappear on Odroid >> XU3. "aplay -L" shows nothing and obviously speaker-test fails. >> >> Applied on v4.15-rc1... any dependencies are missing? >> >> Full boot-logs are here: >> http://www.krzk.eu/#/builders/1/builds/976 >> (test exits on aplay -L). >> >> Should this be dropped? > > > Please add CONFIG_SND_SOC_ODROID=y to you .config. Probably exynos_defconfig > and multi_v7_defconfig should be updated too. That would explain it. Can you send a patch for both of configs? Best regards, Krzysztof