From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752086AbdCIGvz (ORCPT ); Thu, 9 Mar 2017 01:51:55 -0500 Received: from mail.kernel.org ([198.145.29.136]:56794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751845AbdCIGvw (ORCPT ); Thu, 9 Mar 2017 01:51:52 -0500 MIME-Version: 1.0 In-Reply-To: References: <1488489799-18136-1-git-send-email-sergio.prado@e-labworks.com> <20170304081504.unv6sihbmp76ynfy@kozik-lap> <20170306131516.GA6095@n1> <20170308163434.obhtg6fwmjwqv7jm@kozik-lap> From: Krzysztof Kozlowski Date: Thu, 9 Mar 2017 08:42:59 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] pinctrl: samsung: fix segfault when using external interrupts on s3c24xx To: Tomasz Figa Cc: Sergio Prado , Kukjin Kim , Javier Martinez Canillas , Sylwester Nawrocki , "linus.walleij@linaro.org" , linux-arm-kernel , "linux-samsung-soc@vger.kernel.org" , "linux-gpio@vger.kernel.org" , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 9, 2017 at 7:56 AM, Tomasz Figa wrote: > 2017-03-09 1:34 GMT+09:00 Krzysztof Kozlowski : >> On Mon, Mar 06, 2017 at 09:15:16AM -0400, Sergio Prado wrote: >>> Hi Krzysztof, >>> >>> > > This is a regression from commit 8b1bd11c1f8f529057369c5b3702d13fd24e2765. >>> > >>> > Checkpatch should complain here about commit format. >>> > >>> > > >>> > > Tested on FriendlyARM mini2440. >>> > > >>> > >>> > Please add: >>> > Fixes: 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank") >>> > Cc: >>> > >>> >>> OK. >>> >>> > > Signed-off-by: Sergio Prado >>> > > --- >>> > > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 4 ++-- >>> > > 1 file changed, 2 insertions(+), 2 deletions(-) >>> > > >>> > > diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c >>> > > index b82a003546ae..1b8d887796e8 100644 >>> > > --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c >>> > > +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c >>> > > @@ -356,8 +356,8 @@ static inline void s3c24xx_demux_eint(struct irq_desc *desc, >>> > > { >>> > > struct s3c24xx_eint_data *data = irq_desc_get_handler_data(desc); >>> > > struct irq_chip *chip = irq_desc_get_chip(desc); >>> > > - struct irq_data *irqd = irq_desc_get_irq_data(desc); >>> > > - struct samsung_pin_bank *bank = irq_data_get_irq_chip_data(irqd); >>> > > + struct samsung_pinctrl_drv_data *d = data->drvdata; >>> > > + struct samsung_pin_bank *bank = d->pin_banks; >>> > >>> > I think 'pin_banks' point to all banks of given controller not to the >>> > currently accessed one. >>> >>> Understood. I think it worked in my tests because on s3c2440 all banks >>> have the same eint base address. >>> >>> So what do you think is the best approach to solve this problem? >> >> Maybe you can get to this through: >> s3c24xx_eint_domain_data = s3c24xx_eint_data->domains[virq].host_data; >> s3c24xx_eint_domain_data->bank >> >> It is getting slightly more complicated... > > How about the suggestions I made in my reply from March 4 (JST)? Yes, this also looks like solution. I am not sure how much you would like to revert but wouldn't it create duplicated members in pinctrl structures? One for Exynos and other for S3C? Best regards, Krzysztof