From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE9EAC433E2 for ; Thu, 10 Sep 2020 18:37:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EE9321941 for ; Thu, 10 Sep 2020 18:37:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599763070; bh=SRgE3e+cWOee6V2K0Aw2EKLPOh+GtgrkQeeqC/WhKkI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Ub0236FAG7IOgHo67Ly6qNzhC/NwL72dwUztUPeLYNCC9pHTXlXJggv7o2EL7DALH n7Dhg4Ak9au9vSUv20J6XTqZDdvCD4ZKUmt3Tp1kODCNUD662TtYv9Ha5X5+orv17g lTskBfpU9qoaQcMJYESR8R5Kz1kdqzPvX5J24We8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726663AbgIJShs (ORCPT ); Thu, 10 Sep 2020 14:37:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:52090 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726984AbgIJSeb (ORCPT ); Thu, 10 Sep 2020 14:34:31 -0400 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4A1BC2087C; Thu, 10 Sep 2020 18:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599762869; bh=SRgE3e+cWOee6V2K0Aw2EKLPOh+GtgrkQeeqC/WhKkI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iRRR8DCEphKxCESUIOWKSYOGUMgScZXbeOeEcg0yOyRFJbnqmaYlOsiksuwiLjobQ M4uyBus+mshUVHZZ3JgPrAGSIFrgxOqZoEzzZ37YKf8U3tBk8av9U+Y8144ibkRREk PXnrMHTG6GY6MWdGQ00DeKQVPH9cYf3H7WrJDCZw= Received: by mail-ej1-f51.google.com with SMTP id z23so10139662ejr.13; Thu, 10 Sep 2020 11:34:29 -0700 (PDT) X-Gm-Message-State: AOAM5309MZH2hu7qkldGTU7mIu6vR+EodTzY1BZTBk5+Pn51YJBCdv8c 7Oe/ExFWFSLC8z+1Ugwp+aJ3u3mdF3wKah6FmvI= X-Google-Smtp-Source: ABdhPJyqKY0eU5W2IUZveRSdHihYXkn66844ltcGWOZGAN2rPhOWdGk7NLfovjoBdKlH8jBLp9/fUyrxxJec5WeF4cE= X-Received: by 2002:a17:906:af53:: with SMTP id ly19mr9924685ejb.503.1599762867837; Thu, 10 Sep 2020 11:34:27 -0700 (PDT) MIME-Version: 1.0 References: <20200904152404.20636-1-krzk@kernel.org> <20200904152404.20636-13-krzk@kernel.org> <20200907060958.GA4525@kozik-lap> In-Reply-To: From: Krzysztof Kozlowski Date: Thu, 10 Sep 2020 20:34:15 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 12/14] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs To: Rob Herring Cc: linux-clk , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , MTD Maling List , Linux PWM List , "open list:SERIAL DRIVERS" , "open list:THERMAL" , LINUX-WATCHDOG , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Guenter Roeck Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Sep 2020 at 18:51, Rob Herring wrote: > > On Mon, Sep 7, 2020 at 12:10 AM Krzysztof Kozlowski wrote: > > > > On Fri, Sep 04, 2020 at 04:36:39PM -0600, Rob Herring wrote: > > > On Fri, Sep 4, 2020 at 9:25 AM Krzysztof Kozlowski wrote: > > > > > > > > Driver requires different amount of clocks for different SoCs. Describe > > > > these requirements properly to fix dtbs_check warnings like: > > > > > > > > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: clock-names:1: 'gpmi_apb' was expected > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > > > --- > > > > > > > > Changes since v1: > > > > 1. Do not require order of clocks (use pattern). > > > > > > To the extent that you can, you should fix the order in dts files > > > first. If we just adjust the schemas to match the dts files, then > > > what's the point? > > > > The DTSes do not have mixed order of clocks between each other, as fair > > as I remember. It was fix after Sasha Hauer comment that order is not > > necessarily good. > > > > We have the clock-names property, why enforcing the order? > > Because DT/OpenFirmware has always had a defined order for property > values. '*-names' is just extra information. Thanks for the explanation. There are few nonobvious requirements about writing schema which seems many (including me) miss. It might be a good topic for some conference. Too bad ELCE CFP ended some time ago. :) Best regards, Krzysztof