From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 610B9C3A5A9 for ; Wed, 4 Sep 2019 14:28:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37EDD22CE3 for ; Wed, 4 Sep 2019 14:28:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567607325; bh=L76A2ZvdZ49vwh9gPyzYANOjIS9WVsZyi57kx5mf8cQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=c7bknzQ5Yq1a5AolvcnG31ichyzYa3sraKbAXsQbcNvVTJx6zIdqX2qGSt/Hbrpd/ agTHb+7cpfk9Ia5ciLvnThnKJQ1lkUdV/LtCO77pRa2ML895rtGUf+fnW3IxlfkFM9 2fAKxntCLFzl524Fjwg2gVmyLQRpxMTy91McUAFU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730846AbfIDO2o (ORCPT ); Wed, 4 Sep 2019 10:28:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:57464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729809AbfIDO2o (ORCPT ); Wed, 4 Sep 2019 10:28:44 -0400 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 52C1F2341D; Wed, 4 Sep 2019 14:28:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567607322; bh=L76A2ZvdZ49vwh9gPyzYANOjIS9WVsZyi57kx5mf8cQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=szOhtdy3pm0hmLpuZGMow2vaeDvOjEj/9NcUKl3Ye865Ae8MB/Tl+Sip/dXvPxb9B 72hiCdJ/0l/oVbxrbyiOYabDzUdSAJFpf80udg8QExAsVR84ISBvUwLj6bCfquTzob rRp/OA3BeXbrfH/12rQnn4/Hm5WjoM800DRgrq64= Received: by mail-lf1-f49.google.com with SMTP id r134so15222441lff.12; Wed, 04 Sep 2019 07:28:42 -0700 (PDT) X-Gm-Message-State: APjAAAXKsHSWA8QBIvUCi2NhiaW9xiys6xDkf8a0nO3ITrHh+iN4Xd9T jvAfLq8FBPhlkyKV666hx0eZp2YqKOel4DQWN5Y= X-Google-Smtp-Source: APXvYqycXOQpNE+apc0JPS11KQSp+RmtxHn6Ng9LQDVcy4lQi5wxS8ZrsQ1N6swmH4iFFIYS5iVQwDmEz/WmDjOTj6U= X-Received: by 2002:a19:c649:: with SMTP id w70mr24808672lff.33.1567607320399; Wed, 04 Sep 2019 07:28:40 -0700 (PDT) MIME-Version: 1.0 References: <20190904135918.25352-1-yuehaibing@huawei.com> <20190904135918.25352-26-yuehaibing@huawei.com> In-Reply-To: <20190904135918.25352-26-yuehaibing@huawei.com> From: Krzysztof Kozlowski Date: Wed, 4 Sep 2019 16:28:29 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next 25/36] spi: s3c24xx: use devm_platform_ioremap_resource() to simplify code To: YueHaibing Cc: broonie@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, eric@anholt.net, wahrenst@gmx.net, shc_work@mail.ru, agross@kernel.org, khilman@baylibre.com, matthias.bgg@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, kgene@kernel.org, Andi Shyti , palmer@sifive.com, paul.walmsley@sifive.com, baohua@kernel.org, mripard@kernel.org, wens@csie.org, ldewangan@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com, yamada.masahiro@socionext.com, michal.simek@xilinx.com, bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org, "linux-samsung-soc@vger.kernel.org" , linux-riscv@lists.infradead.org, linux-tegra@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Sep 2019 at 16:00, YueHaibing wrote: > > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot This tag does not look real... First of all where is the report? Second, it was reported by coccinelle. Reported-by should be use to give real credits. Best regards, Krzysztof > Signed-off-by: YueHaibing > --- > drivers/spi/spi-s3c24xx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c > index aea8fd9..2d6e37f 100644 > --- a/drivers/spi/spi-s3c24xx.c > +++ b/drivers/spi/spi-s3c24xx.c > @@ -487,7 +487,6 @@ static int s3c24xx_spi_probe(struct platform_device *pdev) > struct s3c2410_spi_info *pdata; > struct s3c24xx_spi *hw; > struct spi_master *master; > - struct resource *res; > int err = 0; > > master = spi_alloc_master(&pdev->dev, sizeof(struct s3c24xx_spi)); > @@ -536,8 +535,7 @@ static int s3c24xx_spi_probe(struct platform_device *pdev) > dev_dbg(hw->dev, "bitbang at %p\n", &hw->bitbang); > > /* find and map our resources */ > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - hw->regs = devm_ioremap_resource(&pdev->dev, res); > + hw->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(hw->regs)) { > err = PTR_ERR(hw->regs); > goto err_no_pdata; > -- > 2.7.4 > >