From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Kukjin Kim <kgene@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-pm@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/5] thermal: exynos: increase the number of trips for exynos542x
Date: Tue, 17 Jul 2018 14:25:07 +0200 [thread overview]
Message-ID: <CAJKOXPe_omjhLMfMScTeXG2k908WT4MesMK5obpA0ejBs=vrfg@mail.gmail.com> (raw)
In-Reply-To: <1531822342-4293-3-git-send-email-linux.amoon@gmail.com>
On 17 July 2018 at 12:12, Anand Moon <linux.amoon@gmail.com> wrote:
> increase the number of trips to support more polling modes,
> changes help supress following warning.
>
> [ 4.231731] thermal thermal_zone0: failed to read out thermal zone (-22)
> [ 4.237190] exynos-tmu 10060000.tmu: More trip points than supported by this TMU.
> [ 4.244661] exynos-tmu 10060000.tmu: 2 trip points should be configured in polling mode.
> [ 4.254821] thermal thermal_zone1: failed to read out thermal zone (-22)
> [ 4.260370] exynos-tmu 10064000.tmu: More trip points than supported by this TMU.
> [ 4.267631] exynos-tmu 10064000.tmu: 2 trip points should be configured in polling mode.
> [ 4.277551] thermal thermal_zone2: failed to read out thermal zone (-22)
> [ 4.283090] exynos-tmu 10068000.tmu: More trip points than supported by this TMU.
> [ 4.290438] exynos-tmu 10068000.tmu: 2 trip points should be configured in polling mode.
> [ 4.300280] thermal thermal_zone3: failed to read out thermal zone (-22)
> [ 4.305711] exynos-tmu 1006c000.tmu: More trip points than supported by this TMU.
> [ 4.313171] exynos-tmu 1006c000.tmu: 2 trip points should be configured in polling mode.
> [ 4.323002] thermal thermal_zone4: failed to read out thermal zone (-22)
>
> CC: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
NAK
Exynos5420/5422/5800 has 4 trip points (understood as in current driver design).
Best regards,
Krzysztof
> ---
> drivers/thermal/samsung/exynos_tmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index 2dbde97..4a2733c 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -935,7 +935,7 @@ static int exynos_map_dt_data(struct platform_device *pdev)
> data->tmu_read = exynos4412_tmu_read;
> data->tmu_set_emulation = exynos4412_tmu_set_emulation;
> data->tmu_clear_irqs = exynos4210_tmu_clear_irqs;
> - data->ntrip = 4;
> + data->ntrip = 8;
> data->gain = 8;
> data->reference_voltage = 16;
> data->efuse_value = 55;
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-07-17 12:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 10:12 [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform Anand Moon
2018-07-17 10:12 ` [PATCH 2/5] thermal: exynos: cleanup of clk err check for exynos_tmu_work Anand Moon
2018-07-17 12:24 ` Krzysztof Kozlowski
2018-07-17 20:08 ` Anand Moon
2018-07-17 20:11 ` Krzysztof Kozlowski
2018-07-17 10:12 ` [PATCH 3/5] thermal: exynos: increase the number of trips for exynos542x Anand Moon
2018-07-17 12:25 ` Krzysztof Kozlowski [this message]
2018-07-17 19:59 ` Anand Moon
2018-07-17 10:12 ` [PATCH 4/5] thermal: exynos: fixed the efuse min/max value for exynos5422 Anand Moon
2018-07-17 12:28 ` Krzysztof Kozlowski
2018-07-17 19:58 ` Anand Moon
2018-07-17 20:07 ` Krzysztof Kozlowski
2018-07-17 10:12 ` [PATCH 5/5] ARM: dts: exynos: add tmu aliases nodes Anand Moon
2018-07-17 12:29 ` Krzysztof Kozlowski
2018-07-17 19:56 ` Anand Moon
2018-07-17 20:01 ` Krzysztof Kozlowski
2018-07-17 12:20 ` [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform Krzysztof Kozlowski
2018-07-17 20:23 ` Anand Moon
2018-07-18 6:17 ` Krzysztof Kozlowski
2018-07-18 9:24 ` Anand Moon
2018-07-18 10:06 ` Krzysztof Kozlowski
2018-07-19 9:52 ` Anand Moon
2018-07-27 22:49 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPe_omjhLMfMScTeXG2k908WT4MesMK5obpA0ejBs=vrfg@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).