From: Krzysztof Kozlowski <krzk@kernel.org>
To: c.manszewski@samsung.com
Cc: linux-crypto@vger.kernel.org, vz@mleia.com,
k.konieczny@partner.samsung.com, herbert@gondor.apana.org.au,
davem@davemloft.net,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] crypto: s5p-sss: Minor code cleanup
Date: Mon, 17 Sep 2018 15:13:52 +0200 [thread overview]
Message-ID: <CAJKOXPe_y7gvgAYAdewtdwhWb=bwk2ni8=_p89ps5Ge6i+pJfg@mail.gmail.com> (raw)
In-Reply-To: <20180913075859eucas1p2bba2f5ab32fea5c4f832abaacaed6c8b~T5q_dx0q42420924209eucas1p2D@eucas1p2.samsung.com>
Thanks Christoph for patches!
On Thu, 13 Sep 2018 at 09:59, Christoph Manszewski
<c.manszewski@samsung.com> wrote:
>
> Modifications in s5p-sss.c:
>
> - remove unnecessary 'goto' statements,
>
No need of empty lines here.
> - change uint_8 and uint_32 to u8 and u32 types,
Please add rationale for this, e.g.: "for consistency in the driver
and making code shorter".
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2018-09-17 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1536825522-6027-1-git-send-email-c.manszewski@samsung.com>
[not found] ` <CGME20180913075857eucas1p2cbccf3cd452a23eb46a234acb37b3a44@eucas1p2.samsung.com>
2018-09-13 7:58 ` [PATCH 1/4] crypto: s5p-sss: Fix race in error handling Christoph Manszewski
2018-09-17 12:59 ` Krzysztof Kozlowski
[not found] ` <CGME20180913075858eucas1p1f528fd0776c32f1c10a3e46f8f2bacd0@eucas1p1.samsung.com>
2018-09-13 7:58 ` [PATCH 2/4] crypto: s5p-sss: Fix whitespace issues Christoph Manszewski
2018-09-17 13:05 ` Krzysztof Kozlowski
[not found] ` <CGME20180913075859eucas1p2bba2f5ab32fea5c4f832abaacaed6c8b@eucas1p2.samsung.com>
2018-09-13 7:58 ` [PATCH 3/4] crypto: s5p-sss: Minor code cleanup Christoph Manszewski
2018-09-17 13:13 ` Krzysztof Kozlowski [this message]
[not found] ` <CGME20180913075901eucas1p2dfb1900b71d70ee64a9d51eb4c8b61fd@eucas1p2.samsung.com>
2018-09-13 7:58 ` [PATCH 4/4] crypto: s5p-sss: Add aes-ctr support Christoph Manszewski
2018-09-17 13:45 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPe_y7gvgAYAdewtdwhWb=bwk2ni8=_p89ps5Ge6i+pJfg@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=c.manszewski@samsung.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=k.konieczny@partner.samsung.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).