From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758144AbbEaGek (ORCPT <rfc822;w@1wt.eu>);
	Sun, 31 May 2015 02:34:40 -0400
Received: from mail-vn0-f42.google.com ([209.85.216.42]:39508 "EHLO
	mail-vn0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751604AbbEaGec (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 31 May 2015 02:34:32 -0400
MIME-Version: 1.0
In-Reply-To: <1403700144-30720-1-git-send-email-gautam.vivek@samsung.com>
References: <CAFp+6iF9GkKWDcqZNV58Z=U3ZDQdgYr8LJBF9t-BpJW90vsHdQ@mail.gmail.com>
	<1403700144-30720-1-git-send-email-gautam.vivek@samsung.com>
Date: Sun, 31 May 2015 15:34:31 +0900
X-Google-Sender-Auth: KUlmO-_KUohSGX9z4eSWsYXjQNs
Message-ID: <CAJKOXPeccCOBd6-jMJSZVtNMR82EUztZexqv1qParC9ad=YOtA@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] usb: ehci-exynos: Make provision for vdd regulators
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
        devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, Jingoo Han <jg1.han@samsung.com>,
        Alan Stern <stern@rowland.harvard.edu>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2014-06-25 21:42 GMT+09:00 Vivek Gautam <gautam.vivek@samsung.com>:
> Facilitate getting required 3.3V and 1.0V VDD supply for
> EHCI controller on Exynos.
>
> With the patches for regulators' nodes merged in 3.15:
> c8c253f ARM: dts: Add regulator entries to smdk5420
> 275dcd2 ARM: dts: add max77686 pmic node for smdk5250,
> the exynos systems turn on only minimal number of regulators.
>
> Until now, the VDD regulator supplies were either turned on
> by the bootloader, or the regulators were enabled by default
> in the kernel, so that the controller drivers did not need to
> care about turning on these regulators on their own.
> This was rather bad about these controller drivers.
> So ensuring now that the controller driver requests the necessary
> VDD regulators (if available, unless there are direct VDD rails),
> and enable them so as to make them working.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Cc: Jingoo Han <jg1.han@samsung.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> ---
>
> Changes from v2:
>  - replaced devm_regulator_get() with devm_regulator_get_optional().
>  - Added Documentation for the vdd supplies for the controller.
>  - Re-did the commit message.

The patch looks useful but it seems it was forgotten. Do you have any
plans to resend it?

Best regards,
Krzysztof