From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753863AbbKBM2B (ORCPT ); Mon, 2 Nov 2015 07:28:01 -0500 Received: from mail-qg0-f43.google.com ([209.85.192.43]:35001 "EHLO mail-qg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753512AbbKBM16 (ORCPT ); Mon, 2 Nov 2015 07:27:58 -0500 MIME-Version: 1.0 In-Reply-To: <56375229.3090906@samsung.com> References: <1446458641-4447-1-git-send-email-alim.akhtar@samsung.com> <1446458641-4447-2-git-send-email-alim.akhtar@samsung.com> <56375229.3090906@samsung.com> Date: Mon, 2 Nov 2015 21:27:57 +0900 X-Google-Sender-Auth: jROccpBxqBiYHHPoVQlmyP-Gw7w Message-ID: Subject: Re: [PATCH 2/2] arm64: dts: exynos7: Enable HS200 mode operation From: Krzysztof Kozlowski To: Alim Akhtar Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kgene@kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-11-02 21:08 GMT+09:00 Alim Akhtar : > Hi Krzysztof, > > > On 11/02/2015 05:28 PM, Krzysztof Kozlowski wrote: >> >> Subject - name of the board at the end (not the name of the SoC): >> arm64: dts: Enable HS200 mode operation on exynos7-espresso >> >> 2015-11-02 19:04 GMT+09:00 Alim Akhtar : >>> >>> This patch enables HS200 mode operation on exynos7 based >>> espresso board. >>> This also remove _broken-cd_ property as per mmc binding documentation >> >> >> s/remove/removes/ >> >>> which say one of the properties between broken-cd and non-removable >> >> >> s/say/says/ >> >>> should be used. And we already use _non-removable_ as emmc mounted >>> on board which is a non-removable device. >>> >>> Signed-off-by: Alim Akhtar >>> --- >>> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >>> b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >>> index 8ce04a0ec928..7f19b99fc85b 100644 >>> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >>> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >>> @@ -405,8 +405,8 @@ >>> &mmc_0 { >>> status = "okay"; >>> num-slots = <1>; >>> - broken-cd; >>> cap-mmc-highspeed; >>> + mmc-hs200-1_8v; >> >> >> The "mmc-ddr-1_8v" should also be supported but I guess you did not >> add it on purpose? >> > Well, I have not tested it, that why didn't added. Will check if this works > then will add. > Thanks for your comments. Right, it would require testing... Just came to my mind. Anyway this is up to you. Best regards, Krzysztof