linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Yeh, Andy" <andy.yeh@intel.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Tomasz Figa <tfiga@chromium.org>,
	Jason Chen <jasonx.z.chen@intel.com>,
	Alan Chiang <alanx.chiang@intel.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] media: i2c: imx258: correct mode to GBGB/RGRG
Date: Wed, 28 Oct 2020 10:56:55 +0100	[thread overview]
Message-ID: <CAJKOXPf6zhpu_3oQZ2bL_FnkBx7-NwH65N_OzVkH=Nh1bYkHxw@mail.gmail.com> (raw)
In-Reply-To: <CAJKOXPePfsRNZkY+L1XM3_iz6dMYFNZAJgrcut9JriuwYkKWsw@mail.gmail.com>

On Wed, 28 Oct 2020 at 10:45, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Wed, 28 Oct 2020 at 10:43, Yeh, Andy <andy.yeh@intel.com> wrote:
> >
> > But the sensor settings for the original submission is to output GRBG Bayer RAW.
> >
> > Regards, Andy
>
> No, not to my knowledge. There are no settings for color output
> because it is fixed to GBGB/RGRG. I was looking a lot into this driver
> (I have few other problems with it, already few other patches posted)
> and I could not find a setting for this in datasheet. If you know the
> setting for the other color - can you point me to it?

And except the datasheet which mentions the specific format, the
testing confirms it. With original color the pictures are pink/purple.
With proper color, the pictures are correct (with more green color as
expected for bayer).

Best regards,
Krzysztof

  reply	other threads:[~2020-10-29  1:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28  9:19 [PATCH] media: i2c: imx258: correct mode to GBGB/RGRG Krzysztof Kozlowski
     [not found] ` <MWHPR11MB0046B799E9AD3648C6F67BFE87170@MWHPR11MB0046.namprd11.prod.outlook.com>
2020-10-28  9:45   ` Krzysztof Kozlowski
2020-10-28  9:56     ` Krzysztof Kozlowski [this message]
     [not found]       ` <20201028100311.GF26150@paasikivi.fi.intel.com>
2020-10-28 10:15         ` Krzysztof Kozlowski
2020-10-28 12:08           ` Tomasz Figa
2020-10-30 11:32             ` Krzysztof Kozlowski
     [not found]         ` <MWHPR11MB0046CCA70D68CE1F3BA4FA4287170@MWHPR11MB0046.namprd11.prod.outlook.com>
2020-10-30 11:29           ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJKOXPf6zhpu_3oQZ2bL_FnkBx7-NwH65N_OzVkH=Nh1bYkHxw@mail.gmail.com' \
    --to=krzk@kernel.org \
    --cc=alanx.chiang@intel.com \
    --cc=andy.yeh@intel.com \
    --cc=jasonx.z.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stable@vger.kernel.org \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).