From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2ACBC43613 for ; Sun, 23 Jun 2019 19:13:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71926205F4 for ; Sun, 23 Jun 2019 19:13:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561317181; bh=AsxupFvBvqb1mH3XUIHGLPhSXMlhWmiYztuijWSq/GQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Hd0iAlubWrfmiaBpyNNGXn4p0MXWRjmq2iDW9gGB/NXpo2nZ4Os514ltQ0MYpx8ny PffYvURuvuXG3nBxJ9WTEJFPYe9+NPhWqT7+2yUkjgt4WUNdAxxC4+e8dPbDjHSE+x K25YmANilgcYlG8oHMdygQed6AeOg09G80M4tf5g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726381AbfFWTMw (ORCPT ); Sun, 23 Jun 2019 15:12:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:57584 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbfFWTMw (ORCPT ); Sun, 23 Jun 2019 15:12:52 -0400 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E215B215EA; Sun, 23 Jun 2019 19:12:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561317171; bh=AsxupFvBvqb1mH3XUIHGLPhSXMlhWmiYztuijWSq/GQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=uJbKaQIyzSWaWU00fx8r+BgyZH9qH3M1R9/GjS5amJxhq2/wMRfKlESl/AGt7ycXB ha0lnIyzb/RrBbLBKIida0P9PPS0bf0gRIpgT8FKt2U21oHebm129KzlVwMeLB3caD MszeI+AS46K1WmuMqEvYmziFe5DO20u0Zy+g9YF0= Received: by mail-lj1-f181.google.com with SMTP id 205so1667253ljj.8; Sun, 23 Jun 2019 12:12:50 -0700 (PDT) X-Gm-Message-State: APjAAAVyih0uk2fF1U3ZGyOS4oqfIBKd5qK5QkrdweGrbLxmIV0Tl+Uj faEJqYQYpRG+Xa1RhqE1inUDwF+9U5igdawMqbA= X-Google-Smtp-Source: APXvYqzc0BAAUk0GcaZ6RKalll+UsB43Pr/w/hhGJmdfj5xhmoT71i8jk/2UViGqeh/ujennhK/FVzPhSD/yw16ZWlw= X-Received: by 2002:a2e:8155:: with SMTP id t21mr26819194ljg.80.1561317169025; Sun, 23 Jun 2019 12:12:49 -0700 (PDT) MIME-Version: 1.0 References: <20190623151313.970-1-tranmanphong@gmail.com> <20190623151313.970-5-tranmanphong@gmail.com> In-Reply-To: <20190623151313.970-5-tranmanphong@gmail.com> From: Krzysztof Kozlowski Date: Sun, 23 Jun 2019 21:12:37 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/15] ARM: exynos: cleanup cppcheck shifting error To: Phong Tran Cc: mark.rutland@arm.com, kstewart@linuxfoundation.org, songliubraving@fb.com, andrew@lunn.ch, peterz@infradead.org, nsekhar@ti.com, ast@kernel.org, jolsa@redhat.com, netdev@vger.kernel.org, gerg@uclinux.org, lorenzo.pieralisi@arm.com, will@kernel.org, "linux-samsung-soc@vger.kernel.org" , daniel@iogearbox.net, festevam@gmail.com, gregory.clement@bootlin.com, allison@lohutok.net, linux@armlinux.org.uk, haojian.zhuang@gmail.com, bgolaszewski@baylibre.com, tony@atomide.com, mingo@redhat.com, linux-imx@nxp.com, yhs@fb.com, sebastian.hesselbarth@gmail.com, illusionist.neo@gmail.com, jason@lakedaemon.net, liviu.dudau@arm.com, s.hauer@pengutronix.de, acme@kernel.org, lkundrak@v3.sk, robert.jarzmik@free.fr, dmg@turingmachine.org, swinslow@gmail.com, namhyung@kernel.org, tglx@linutronix.de, linux-omap@vger.kernel.org, alexander.sverdlin@gmail.com, linux-arm-kernel@lists.infradead.org, info@metux.net, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com, hsweeten@visionengravers.com, kgene@kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, bpf@vger.kernel.org, shawnguo@kernel.org, kafai@fb.com, daniel@zonque.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 23 Jun 2019 at 17:14, Phong Tran wrote: > > [arch/arm/mach-exynos/suspend.c:288]: (error) Shifting signed 32-bit > value by 31 bits is undefined behaviour > > Signed-off-by: Phong Tran > --- > arch/arm/mach-exynos/suspend.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Let's switch to BIT macro. It will solve the problem and is preferred way of coding. Best regards, Krzysztof