From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/16] mfd: bcm590xx: drop of_match_ptr from of_device_id table
Date: Fri, 27 Nov 2020 09:17:33 +0100 [thread overview]
Message-ID: <CAJKOXPfdEbax7Z4xpu2QcLSND6fvWK__5hTKOESaO0n2pBMhtA@mail.gmail.com> (raw)
In-Reply-To: <20201127080619.GJ2455276@dell>
On Fri, 27 Nov 2020 at 09:06, Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 20 Nov 2020, Krzysztof Kozlowski wrote:
>
> > The driver can match only via the DT table so the table should be always
> > used and the of_match_ptr does not have any sense (this also allows ACPI
> > matching via PRP0001, even though it is not relevant here). This fixes
> > compile warning (!CONFIG_OF on x86_64):
> >
> > drivers/mfd/bcm590xx.c:95:34: warning: ‘bcm590xx_of_match’ defined but not used [-Wunused-const-variable=]
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > drivers/mfd/bcm590xx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Couple of small points:
>
> - Patch-sets, particularly large ones should have a cover letter.
> - Subject lines follow English grammar conventions and should start
> with an uppercase character.
Thanks for fixing this. I am not a native English speaker and I make
mistakes. Either it is a grammar or convention mistake, I would
appreciate it if you point them out, so I could learn from them.
About the "start with an uppercase character", I actually on purpose
changed my approach some time ago after seeing more senior kernel
developers using this method (see commits from Linus Torvalds, Andrew
Morton). After the subsystem prefix "mfd: ...." they start with
lowercase. If you still insist that commit titles in MFD subsystem
should use capital letter after the prefix, I will try to remember and
follow this approach when sending patches to you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-11-27 8:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 16:21 [PATCH 01/16] mfd: bcm590xx: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 02/16] mfd: da9055: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 03/16] mfd: da9062: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 04/16] mfd: da9063: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 05/16] mfd: da9150: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 06/16] mfd: ene-kb3930: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 07/16] mfd: fsl-imx25: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 08/16] mfd: max77650: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 09/16] mfd: max77686: " Krzysztof Kozlowski
2020-11-23 5:12 ` Chanwoo Choi
2020-11-20 16:21 ` [PATCH 10/16] mfd: mt6397: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 11/16] mfd: rt5033: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 12/16] mfd: stmfx: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 13/16] mfd: sun4i: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 14/16] mfd: wm8994: " Krzysztof Kozlowski
2020-11-20 17:02 ` Charles Keepax
2020-11-20 16:21 ` [PATCH 15/16] mfd: axp20x: skip of_device_id table when !CONFIG_OF Krzysztof Kozlowski
2020-11-20 16:41 ` Chen-Yu Tsai
2020-11-20 16:21 ` [PATCH 16/16] mfd: twl6030: mark of_device_id table as maybe unused Krzysztof Kozlowski
2020-11-27 8:06 ` [PATCH 01/16] mfd: bcm590xx: drop of_match_ptr from of_device_id table Lee Jones
2020-11-27 8:17 ` Krzysztof Kozlowski [this message]
2020-11-27 9:17 ` Lee Jones
2020-11-27 11:37 ` Miguel Ojeda
2020-11-27 13:20 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPfdEbax7Z4xpu2QcLSND6fvWK__5hTKOESaO0n2pBMhtA@mail.gmail.com \
--to=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).