From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B58C2BA83 for ; Fri, 14 Feb 2020 07:54:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CAB024654 for ; Fri, 14 Feb 2020 07:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581666877; bh=uUqCY41ymz6hiHKzFlEzisjq83c9h686/Ry4dcKtL8o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=JTxxIwSCW4O7o3ej/BE99OToAzbcOxkqCmweDv33vtDw/HbhLBiL/cAlryeLx71DU Cl7G7S/aL9Zvb9p/zr4sjeC21iXlgS3faSywh+ZW81CIrR/WIqYaaiVQAEq70d/NqR cGfy1FiOFYtpNnUge/TMOv4zP9vBiOSmw0gTVhV0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728801AbgBNHyg (ORCPT ); Fri, 14 Feb 2020 02:54:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:55676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbgBNHyg (ORCPT ); Fri, 14 Feb 2020 02:54:36 -0500 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF17124670 for ; Fri, 14 Feb 2020 07:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581666876; bh=uUqCY41ymz6hiHKzFlEzisjq83c9h686/Ry4dcKtL8o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nO8VWAnq6enkWoVO1KQOYen9dfbnv11SjtbXp+5e9AWrErsEw2EGJzm9oxQUQQj5b GTGWK9hnefBoQm7ycijq0ujxWXUHB2dkpOXCXZq69cSbfBPP9lVazagzVCiSWZnZRh JiDRfIdqXWtwoYtPWpK9YWF4OeGkaWHDqt9+6+t0= Received: by mail-lj1-f175.google.com with SMTP id r19so9641209ljg.3 for ; Thu, 13 Feb 2020 23:54:35 -0800 (PST) X-Gm-Message-State: APjAAAUTC/BbMSa5veLIeZi9vbYvRkp25WSGim1ncfQXswUk6lo7tORG D0+OsDqMhxOzu7ZCJQgLLWPLab9yDroqgPedz+I= X-Google-Smtp-Source: APXvYqxYBogvyVwCKY0O00NON1CcUeROLB0hSLARDR8eSX50Ch0burvTbanjgmW65jT/Dd4xwcQQTYXH4O/btXWthPQ= X-Received: by 2002:a2e:9a11:: with SMTP id o17mr1196010lji.256.1581666873795; Thu, 13 Feb 2020 23:54:33 -0800 (PST) MIME-Version: 1.0 References: <20200210061544.7600-1-yuehaibing@huawei.com> <9351a746-8823-ee26-70da-fd3127a02c91@linux.intel.com> In-Reply-To: From: Krzysztof Kozlowski Date: Fri, 14 Feb 2020 08:54:21 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [alsa-devel] [PATCH -next] ASoC: SOF: imx8: Fix randbuild error To: Daniel Baluta Cc: Yuehaibing , Pierre-Louis Bossart , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , Daniel Baluta , Linux-ALSA , Linux Kernel Mailing List , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Feb 2020 at 22:12, Daniel Baluta wrote: > > > > Visible symbols usually should not be selected. The same with symbols > > with dependencies. The docs have this rule mentioned. > > You mean if module X depends on module Y, we shouldn't use select? > But this exactly what this patch does :). There are two different cases (hints against using select): 1. select A, if A is a user-visible (possible to select) option, 2. select only A if A depends on B (and B is kind of independent). These cases are discouraged. > The problem here is that when X depends on Y, and X=y and Y=m > when we try to compile X if get an error because we cannot find a symbol from Y. > > I think if X depends on Y, and X is forced to "y" then also Y should > be forced on "y". If X is bool, then depends should be =y. If X is tristate, then probably you need something like: depends (Y!=m || m) There is also solution like: config CEPH_FSCACHE depends on CEPH_FS=m && FSCACHE || CEPH_FS=y && FSCACHE=y but it works if the upper-level option (CEPH_FS) is a tristate. Best regards, Krzysztof