From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751595AbcAXFK5 (ORCPT ); Sun, 24 Jan 2016 00:10:57 -0500 Received: from mail-io0-f175.google.com ([209.85.223.175]:34604 "EHLO mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892AbcAXFKz (ORCPT ); Sun, 24 Jan 2016 00:10:55 -0500 MIME-Version: 1.0 From: Sultan Qasim Date: Sun, 24 Jan 2016 00:10:35 -0500 Message-ID: Subject: Mis-backport in af_unix patch for Linux 3.10.95 To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello all, I'm an outsider to the Linux kernel community, so I apologize if this is not the right channel to mention this. I noticed that the backported version of the patch "af_unix: Revert 'lock_interruptible' in stream receive code" in Linux 3.10.95 seems to have removed the mutex_lock_interruptible from the wrong function. Here is the backported patch: https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=3a57e783016bf43ab9326172217f564941b85b17 Here is the original: https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/net/unix/af_unix.c?id=3822b5c2fc62e3de8a0f33806ff279fb7df92432 Was it not meant to be removed from unix_stream_recvmsg instead of unix_dgram_recvmsg? Also, the variable called "noblock" needs to be removed from the function being changed to prevent unused variable warnings. Sultan Q. Khan