From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4746C4332F for ; Sun, 20 Nov 2022 18:34:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229746AbiKTSeH (ORCPT ); Sun, 20 Nov 2022 13:34:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbiKTSeF (ORCPT ); Sun, 20 Nov 2022 13:34:05 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C87310AD for ; Sun, 20 Nov 2022 10:34:04 -0800 (PST) Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 859523F535 for ; Sun, 20 Nov 2022 18:34:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1668969240; bh=dG5PIPBE2GHp36S+UZp6jaADUVR1TUqcHiS7ewQr4PU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=OOfW4X9WAmhzquOYL/9Ch6Q+sF4hCdYRNArwmgM2RIMOvgG+sI4OWprzSErPc4X0u 08ug1l9c6FkDZ3xVTMTVSebjPCQxVfJ0nQeDWjq2Uh/6E89TxEwq+Ys0E+lroMoQw6 v8BSHZ+NzM2xv+Zcorlir28JYk6WihWTs4bxEawSu0HXgPA0Q8xHb5hdp2ETk2C8RR oc+MNRlOiTL4GkbY37xA0ADibOjHSB4LVihLrNN7EZJxOtpwRUc9TVvb/eA12IdXOR 6MJoxkI1rP2QH4mAg14QMdsO/mLkZNUvGz2tptfvMqqFT86f1txAxDy2F9YwqYd2rr pI82xTBby17xw== Received: by mail-yb1-f200.google.com with SMTP id f126-20020a255184000000b006cb2aebd124so9228286ybb.11 for ; Sun, 20 Nov 2022 10:34:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dG5PIPBE2GHp36S+UZp6jaADUVR1TUqcHiS7ewQr4PU=; b=fDW2Qdt4lOSouvgtS8jKTTTlbOvw6J8+o9ZtqUOt2yC6PH5wsOX824XhZpiChs7DTh OWpbKEwciGp/MTmeKQTd4zNWb0lck0J8iZuY+su/4HBF6C9qyIkexd0Wt9Ne8F6HOkMd 7mycGcHKbwe8bR6nAc+cilGDJ8rpzXrMdoAg/kXsDXDyud01b4UlMZuEohxDlkIEe6w6 qf7fO5Xug+SsBjA5ZFHTbuA3qsNmF95M6x9+73AJDaqo53WitXkPZRYE8mpUHH8S4zZ4 7vPKIHDVAFACSrUwzW9kGZSeiAz1PXKbGvakqJlpG75uLAQBMeH6jrMkYjH85H0ftOH6 V7GQ== X-Gm-Message-State: ANoB5pk9vVp0Tivy1IMMGunxFwqlwdSTO+/RETSWTL0CCOTA/liBeGRE ercdtz25q5UrCMXYZ/rtXkvrYoV8zwx7wB9nJJ4+QWH4EFFEfJQZ+no4r9ZUaKhmq4JfvoRtJaP O2EfdhllIWj2BdAmA23BtNQJi2ef7uJeymAc1LuwO9CUxdOvilRnVUMOeAA== X-Received: by 2002:a25:ce45:0:b0:6de:39c1:9cb3 with SMTP id x66-20020a25ce45000000b006de39c19cb3mr4557856ybe.469.1668969238857; Sun, 20 Nov 2022 10:33:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf7D5wi+VzurwIIfkrVA4oYQhDY3qKyG8JzAj9UB/Ym70XQ6dHirKxuyiYefeUUYc4HmKc2qyRnz8/hamiUIt4E= X-Received: by 2002:a25:ce45:0:b0:6de:39c1:9cb3 with SMTP id x66-20020a25ce45000000b006de39c19cb3mr4557849ybe.469.1668969238637; Sun, 20 Nov 2022 10:33:58 -0800 (PST) MIME-Version: 1.0 References: <20221120082114.3030-1-jszhang@kernel.org> <20221120082114.3030-6-jszhang@kernel.org> In-Reply-To: From: Emil Renner Berthing Date: Sun, 20 Nov 2022 19:33:42 +0100 Message-ID: Subject: Re: [PATCH 5/7] riscv: dts: bouffalolab: add the bl808 SoC base device tree To: Conor Dooley Cc: Jisheng Zhang , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jiri Slaby , linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 20 Nov 2022 at 18:51, Conor Dooley wrote: > > On Sun, Nov 20, 2022 at 03:57:17PM +0100, Emil Renner Berthing wrote: > > On Sun, 20 Nov 2022 at 09:32, Jisheng Zhang wrote: > > > > > > Add a baisc dtsi for the bouffalolab bl808 SoC. > > > > + xtal: xtal-clk { > > > + compatible = "fixed-clock"; > > > + clock-frequency = <40000000>; > > > > This was discussed many times before, but I think the conclusion was > > that the frequency is a property of the crystal on the board, so this > > should be 0 in the SoC dtsi, and then overwritten in the board device > > tree. > > Or set nothing in soc.dtsi so that dtbs_check can be used to see if > someone forgot to set a clock for their board? Sure. That sounds even better. > > > + clock-output-names = "xtal"; > > > + #clock-cells = <0>; > > > + }; >