linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"
@ 2022-01-06 12:24 Wolfram Sang
  2022-01-07 20:28 ` Wolfram Sang
  2022-01-12  9:32 ` Wolfram Sang
  0 siblings, 2 replies; 11+ messages in thread
From: Wolfram Sang @ 2022-01-06 12:24 UTC (permalink / raw)
  To: linux-i2c
  Cc: Tareque Md.Hanif, Konstantin Kharlamov, linux-kernel, amd-gfx,
	Bibby Hsieh, Marek Szyprowski, Hsin-Yi Wang, Matthias Brugger,
	Wolfram Sang

This largely reverts commit 5a7b95fb993ec399c8a685552aa6a8fc995c40bd. It
breaks suspend with AMD GPUs, and we couldn't incrementally fix it. So,
let's remove the code and go back to the drawing board. We keep the
header extension to not break drivers already populating the regulator.
We expect to re-add the code handling it soon.

Reported-by: "Tareque Md.Hanif" <tarequemd.hanif@yahoo.com>
Link: https://lore.kernel.org/r/1295184560.182511.1639075777725@mail.yahoo.com
Reported-by: Konstantin Kharlamov <hi-angel@yandex.ru>
Link: https://lore.kernel.org/r/7143a7147978f4104171072d9f5225d2ce355ec1.camel@yandex.ru
BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1850
Signed-off-by: Wolfram Sang <wsa@kernel.org>
---

So far, I tested it on a Renesas R-Car M3-N board verifying that I2C
still works. I'll apply it to my for-next branch right away to get the
buildbots involved as well. But I am still open for comments until I
apply it to my for-current branch, probably tomorrow.

 drivers/i2c/i2c-core-base.c | 95 -------------------------------------
 1 file changed, 95 deletions(-)

diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index f193f9058584..73253e667de1 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -466,14 +466,12 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client)
 static int i2c_device_probe(struct device *dev)
 {
 	struct i2c_client	*client = i2c_verify_client(dev);
-	struct i2c_adapter	*adap;
 	struct i2c_driver	*driver;
 	int status;
 
 	if (!client)
 		return 0;
 
-	adap = client->adapter;
 	client->irq = client->init_irq;
 
 	if (!client->irq) {
@@ -539,14 +537,6 @@ static int i2c_device_probe(struct device *dev)
 
 	dev_dbg(dev, "probe\n");
 
-	if (adap->bus_regulator) {
-		status = regulator_enable(adap->bus_regulator);
-		if (status < 0) {
-			dev_err(&adap->dev, "Failed to enable bus regulator\n");
-			goto err_clear_wakeup_irq;
-		}
-	}
-
 	status = of_clk_set_defaults(dev->of_node, false);
 	if (status < 0)
 		goto err_clear_wakeup_irq;
@@ -605,10 +595,8 @@ static int i2c_device_probe(struct device *dev)
 static void i2c_device_remove(struct device *dev)
 {
 	struct i2c_client	*client = to_i2c_client(dev);
-	struct i2c_adapter      *adap;
 	struct i2c_driver	*driver;
 
-	adap = client->adapter;
 	driver = to_i2c_driver(dev->driver);
 	if (driver->remove) {
 		int status;
@@ -623,8 +611,6 @@ static void i2c_device_remove(struct device *dev)
 	devres_release_group(&client->dev, client->devres_group_id);
 
 	dev_pm_domain_detach(&client->dev, !i2c_acpi_waive_d0_probe(dev));
-	if (!pm_runtime_status_suspended(&client->dev) && adap->bus_regulator)
-		regulator_disable(adap->bus_regulator);
 
 	dev_pm_clear_wake_irq(&client->dev);
 	device_init_wakeup(&client->dev, false);
@@ -634,86 +620,6 @@ static void i2c_device_remove(struct device *dev)
 		pm_runtime_put(&client->adapter->dev);
 }
 
-#ifdef CONFIG_PM_SLEEP
-static int i2c_resume_early(struct device *dev)
-{
-	struct i2c_client *client = i2c_verify_client(dev);
-	int err;
-
-	if (!client)
-		return 0;
-
-	if (pm_runtime_status_suspended(&client->dev) &&
-		client->adapter->bus_regulator) {
-		err = regulator_enable(client->adapter->bus_regulator);
-		if (err)
-			return err;
-	}
-
-	return pm_generic_resume_early(&client->dev);
-}
-
-static int i2c_suspend_late(struct device *dev)
-{
-	struct i2c_client *client = i2c_verify_client(dev);
-	int err;
-
-	if (!client)
-		return 0;
-
-	err = pm_generic_suspend_late(&client->dev);
-	if (err)
-		return err;
-
-	if (!pm_runtime_status_suspended(&client->dev) &&
-		client->adapter->bus_regulator)
-		return regulator_disable(client->adapter->bus_regulator);
-
-	return 0;
-}
-#endif
-
-#ifdef CONFIG_PM
-static int i2c_runtime_resume(struct device *dev)
-{
-	struct i2c_client *client = i2c_verify_client(dev);
-	int err;
-
-	if (!client)
-		return 0;
-
-	if (client->adapter->bus_regulator) {
-		err = regulator_enable(client->adapter->bus_regulator);
-		if (err)
-			return err;
-	}
-
-	return pm_generic_runtime_resume(&client->dev);
-}
-
-static int i2c_runtime_suspend(struct device *dev)
-{
-	struct i2c_client *client = i2c_verify_client(dev);
-	int err;
-
-	if (!client)
-		return 0;
-
-	err = pm_generic_runtime_suspend(&client->dev);
-	if (err)
-		return err;
-
-	if (client->adapter->bus_regulator)
-		return regulator_disable(client->adapter->bus_regulator);
-	return 0;
-}
-#endif
-
-static const struct dev_pm_ops i2c_device_pm = {
-	SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late, i2c_resume_early)
-	SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume, NULL)
-};
-
 static void i2c_device_shutdown(struct device *dev)
 {
 	struct i2c_client *client = i2c_verify_client(dev);
@@ -773,7 +679,6 @@ struct bus_type i2c_bus_type = {
 	.probe		= i2c_device_probe,
 	.remove		= i2c_device_remove,
 	.shutdown	= i2c_device_shutdown,
-	.pm		= &i2c_device_pm,
 };
 EXPORT_SYMBOL_GPL(i2c_bus_type);
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"
  2022-01-06 12:24 [PATCH] Revert "i2c: core: support bus regulator controlling in adapter" Wolfram Sang
@ 2022-01-07 20:28 ` Wolfram Sang
  2022-01-12  9:32 ` Wolfram Sang
  1 sibling, 0 replies; 11+ messages in thread
From: Wolfram Sang @ 2022-01-07 20:28 UTC (permalink / raw)
  To: linux-i2c
  Cc: Tareque Md.Hanif, Konstantin Kharlamov, linux-kernel, amd-gfx,
	Bibby Hsieh, Marek Szyprowski, Hsin-Yi Wang, Matthias Brugger

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

On Thu, Jan 06, 2022 at 01:24:52PM +0100, Wolfram Sang wrote:
> This largely reverts commit 5a7b95fb993ec399c8a685552aa6a8fc995c40bd. It
> breaks suspend with AMD GPUs, and we couldn't incrementally fix it. So,
> let's remove the code and go back to the drawing board. We keep the
> header extension to not break drivers already populating the regulator.
> We expect to re-add the code handling it soon.
> 
> Reported-by: "Tareque Md.Hanif" <tarequemd.hanif@yahoo.com>
> Link: https://lore.kernel.org/r/1295184560.182511.1639075777725@mail.yahoo.com
> Reported-by: Konstantin Kharlamov <hi-angel@yandex.ru>
> Link: https://lore.kernel.org/r/7143a7147978f4104171072d9f5225d2ce355ec1.camel@yandex.ru
> BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1850
> Signed-off-by: Wolfram Sang <wsa@kernel.org>

Applied to for-current, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"
  2022-01-06 12:24 [PATCH] Revert "i2c: core: support bus regulator controlling in adapter" Wolfram Sang
  2022-01-07 20:28 ` Wolfram Sang
@ 2022-01-12  9:32 ` Wolfram Sang
  2022-01-12  9:51   ` Konstantin Kharlamov
  1 sibling, 1 reply; 11+ messages in thread
From: Wolfram Sang @ 2022-01-12  9:32 UTC (permalink / raw)
  To: linux-i2c
  Cc: Tareque Md.Hanif, Konstantin Kharlamov, linux-kernel, amd-gfx,
	Bibby Hsieh, Marek Szyprowski, Hsin-Yi Wang, Matthias Brugger

[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]

Hi everyone,

On Thu, Jan 06, 2022 at 01:24:52PM +0100, Wolfram Sang wrote:
> This largely reverts commit 5a7b95fb993ec399c8a685552aa6a8fc995c40bd. It
> breaks suspend with AMD GPUs, and we couldn't incrementally fix it. So,
> let's remove the code and go back to the drawing board. We keep the
> header extension to not break drivers already populating the regulator.
> We expect to re-add the code handling it soon.
> 
> Reported-by: "Tareque Md.Hanif" <tarequemd.hanif@yahoo.com>
> Link: https://lore.kernel.org/r/1295184560.182511.1639075777725@mail.yahoo.com
> Reported-by: Konstantin Kharlamov <hi-angel@yandex.ru>
> Link: https://lore.kernel.org/r/7143a7147978f4104171072d9f5225d2ce355ec1.camel@yandex.ru
> BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1850
> Signed-off-by: Wolfram Sang <wsa@kernel.org>

So, it has been reverted now. Is someone of the original patch
submitters interested in re-adding it? And would the reporters of the
regression be available for further testing?

Thanks and happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"
  2022-01-12  9:32 ` Wolfram Sang
@ 2022-01-12  9:51   ` Konstantin Kharlamov
       [not found]     ` <4dfbee97-14c2-718b-9cbd-fdeeace96f59@yahoo.com>
  0 siblings, 1 reply; 11+ messages in thread
From: Konstantin Kharlamov @ 2022-01-12  9:51 UTC (permalink / raw)
  To: Wolfram Sang, linux-i2c
  Cc: Tareque Md.Hanif, linux-kernel, amd-gfx, Bibby Hsieh,
	Marek Szyprowski, Hsin-Yi Wang, Matthias Brugger

On Wed, 2022-01-12 at 10:32 +0100, Wolfram Sang wrote:
> Hi everyone,
> 
> On Thu, Jan 06, 2022 at 01:24:52PM +0100, Wolfram Sang wrote:
> > This largely reverts commit 5a7b95fb993ec399c8a685552aa6a8fc995c40bd. It
> > breaks suspend with AMD GPUs, and we couldn't incrementally fix it. So,
> > let's remove the code and go back to the drawing board. We keep the
> > header extension to not break drivers already populating the regulator.
> > We expect to re-add the code handling it soon.
> > 
> > Reported-by: "Tareque Md.Hanif" <tarequemd.hanif@yahoo.com>
> > Link:
> > https://lore.kernel.org/r/1295184560.182511.1639075777725@mail.yahoo.com
> > Reported-by: Konstantin Kharlamov <hi-angel@yandex.ru>
> > Link:
> > https://lore.kernel.org/r/7143a7147978f4104171072d9f5225d2ce355ec1.camel@yandex.ru
> > BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1850
> > Signed-off-by: Wolfram Sang <wsa@kernel.org>
> 
> So, it has been reverted now. Is someone of the original patch
> submitters interested in re-adding it? And would the reporters of the
> regression be available for further testing?

I am available for further testing.

> Thanks and happy hacking,
> 
>    Wolfram
> 


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"
       [not found]     ` <4dfbee97-14c2-718b-9cbd-fdeeace96f59@yahoo.com>
@ 2022-01-12 10:58       ` Hsin-Yi Wang
  2022-01-12 12:24         ` Hsin-Yi Wang
       [not found]         ` <6121a782-6927-f033-1c09-ffe4ad7700ae@yahoo.com>
  0 siblings, 2 replies; 11+ messages in thread
From: Hsin-Yi Wang @ 2022-01-12 10:58 UTC (permalink / raw)
  To: Tareque Md Hanif
  Cc: Wolfram Sang, linux-i2c, linux-kernel, amd-gfx, Bibby Hsieh,
	Marek Szyprowski, Matthias Brugger

hi Konstantin and Tareque,

Can you help provide logs if we apply
5a7b95fb993ec399c8a685552aa6a8fc995c40bd but revert
8d35a2596164c1c9d34d4656fd42b445cd1e247f?

Thanks

On Wed, Jan 12, 2022 at 6:02 PM Tareque Md Hanif
<tarequemd.hanif@yahoo.com> wrote:
>
>
> On 1/12/22 15:51, Wolfram Sang wrote:
> > would the reporters of the
> > regression be available for further testing?
> Sure. I am available.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"
  2022-01-12 10:58       ` Hsin-Yi Wang
@ 2022-01-12 12:24         ` Hsin-Yi Wang
       [not found]         ` <6121a782-6927-f033-1c09-ffe4ad7700ae@yahoo.com>
  1 sibling, 0 replies; 11+ messages in thread
From: Hsin-Yi Wang @ 2022-01-12 12:24 UTC (permalink / raw)
  To: Tareque Md Hanif
  Cc: Wolfram Sang, linux-i2c, linux-kernel, amd-gfx, Bibby Hsieh,
	Marek Szyprowski, Matthias Brugger

On Wed, Jan 12, 2022 at 6:58 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> hi Konstantin and Tareque,
>
> Can you help provide logs if we apply
> 5a7b95fb993ec399c8a685552aa6a8fc995c40bd but revert
> 8d35a2596164c1c9d34d4656fd42b445cd1e247f?
>
Another thing might be helpful to test with:

after apply 5a7b95fb993ec399c8a685552aa6a8fc995c40bd
1. delete SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late,
i2c_resume_early) and function i2c_suspend_late() and
i2c_resume_early().
2. delete SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume,
NULL) and function i2c_runtime_suspend() and i2c_runtime_resume().

Does it still fail if we do 1 or 2?

Sorry that we don't have a platform with intel CPU and amd GPU
combination to test with.


> Thanks
>
> On Wed, Jan 12, 2022 at 6:02 PM Tareque Md Hanif
> <tarequemd.hanif@yahoo.com> wrote:
> >
> >
> > On 1/12/22 15:51, Wolfram Sang wrote:
> > > would the reporters of the
> > > regression be available for further testing?
> > Sure. I am available.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"
       [not found]         ` <6121a782-6927-f033-1c09-ffe4ad7700ae@yahoo.com>
@ 2022-01-15 17:26           ` Hsin-Yi Wang
       [not found]             ` <363432688.323955.1642272250312@mail.yahoo.com>
  0 siblings, 1 reply; 11+ messages in thread
From: Hsin-Yi Wang @ 2022-01-15 17:26 UTC (permalink / raw)
  To: Tareque Md Hanif
  Cc: Wolfram Sang, linux-i2c, linux-kernel, amd-gfx, Bibby Hsieh,
	Marek Szyprowski, Matthias Brugger

hi Tareque,


On Fri, Jan 14, 2022 at 6:09 PM Tareque Md Hanif
<tarequemd.hanif@yahoo.com> wrote:
>
> Hi Hsin-Yi,
>
> On 1/12/22 16:58, Hsin-Yi Wang wrote:
>
> Can you help provide logs if we apply
> 5a7b95fb993ec399c8a685552aa6a8fc995c40bd but revert
> 8d35a2596164c1c9d34d4656fd42b445cd1e247f?
>
> Issue still exists. journalctl log attached in revert_8d.txt
>
>
> > after apply 5a7b95fb993ec399c8a685552aa6a8fc995c40bd
> > 1. delete SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late,
> > i2c_resume_early) and function i2c_suspend_late() and
> > i2c_resume_early().
>
> No issues. journalctl log attached in test1.txt
>
>
> > 2. delete SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume,
> > NULL) and function i2c_runtime_suspend() and i2c_runtime_resume().
>
> Issue exists. journalctl log attached in test2.txt

Thanks for the testing.
Can you help us test if applying the following patch on top of
5a7b95fb993ec399c8a685552aa6a8fc995c40bd works? Thanks

diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 9eb4009cb250..6b046012aa08 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -484,7 +484,7 @@ static int i2c_resume_early(struct device *dev)
        struct i2c_client *client = i2c_verify_client(dev);
        int err;

-       if (!client)
+       if (!client || dev_pm_skip_resume(dev))
                return 0;

        if (pm_runtime_status_suspended(&client->dev) &&
@@ -502,7 +502,7 @@ static int i2c_suspend_late(struct device *dev)
        struct i2c_client *client = i2c_verify_client(dev);
        int err;

-       if (!client)
+       if (!client || dev_pm_skip_suspend(dev))
                return 0;

        err = pm_generic_suspend_late(&client->dev);

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"
       [not found]             ` <363432688.323955.1642272250312@mail.yahoo.com>
@ 2022-02-04 18:18               ` Hsin-Yi Wang
       [not found]                 ` <297191986.3285872.1644002564779@mail.yahoo.com>
  0 siblings, 1 reply; 11+ messages in thread
From: Hsin-Yi Wang @ 2022-02-04 18:18 UTC (permalink / raw)
  To: Tareque Md.Hanif
  Cc: Wolfram Sang, linux-i2c, linux-kernel, amd-gfx, Bibby Hsieh,
	Marek Szyprowski, Matthias Brugger

On Sun, Jan 16, 2022 at 2:44 AM Tareque Md.Hanif
<tarequemd.hanif@yahoo.com> wrote:
>
> Hi Hsin-Yi,
>
> The issue still exists. I reverted a19f75de73c220b4496d2aefb7a605dd032f7c01 (the commit that reverted 5a7b95fb993ec399c8a685552aa6a8fc995c40bd) and manually applied the patch (tags/v5.16). journalctl attached.

hi Tareque,

Can you apply the same setting[1] again and with this patch to see if
the issue is still there?
https://github.com/torvalds/linux/commit/6dc8265f9803ccb7e5da804e01601f0c14f270e0

[1] reverted a19f75de73c220b4496d2aefb7a605dd032f7c01 (the commit that
reverted 5a7b95fb993ec399c8a685552aa6a8fc995c40bd) and manually
applied the patch (tags/v5.16)

Thanks
>
> Regards,
>
> Tareque
>
> On Saturday, January 15, 2022, 11:27:07 PM GMT+6, Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
>
> hi Tareque,
>
>
> On Fri, Jan 14, 2022 at 6:09 PM Tareque Md Hanif
> <tarequemd.hanif@yahoo.com> wrote:
> >
> > Hi Hsin-Yi,
> >
> > On 1/12/22 16:58, Hsin-Yi Wang wrote:
> >
> > Can you help provide logs if we apply
> > 5a7b95fb993ec399c8a685552aa6a8fc995c40bd but revert
> > 8d35a2596164c1c9d34d4656fd42b445cd1e247f?
> >
> > Issue still exists. journalctl log attached in revert_8d.txt
> >
> >
> > > after apply 5a7b95fb993ec399c8a685552aa6a8fc995c40bd
> > > 1. delete SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late,
> > > i2c_resume_early) and function i2c_suspend_late() and
> > > i2c_resume_early().
> >
> > No issues. journalctl log attached in test1.txt
> >
> >
> > > 2. delete SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume,
> > > NULL) and function i2c_runtime_suspend() and i2c_runtime_resume().
> >
> > Issue exists. journalctl log attached in test2.txt
>
>
> Thanks for the testing.
> Can you help us test if applying the following patch on top of
> 5a7b95fb993ec399c8a685552aa6a8fc995c40bd works? Thanks
>
> diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
> index 9eb4009cb250..6b046012aa08 100644
> --- a/drivers/i2c/i2c-core-base.c
> +++ b/drivers/i2c/i2c-core-base.c
> @@ -484,7 +484,7 @@ static int i2c_resume_early(struct device *dev)
>         struct i2c_client *client = i2c_verify_client(dev);
>         int err;
>
> -      if (!client)
> +      if (!client || dev_pm_skip_resume(dev))
>                 return 0;
>
>         if (pm_runtime_status_suspended(&client->dev) &&
> @@ -502,7 +502,7 @@ static int i2c_suspend_late(struct device *dev)
>         struct i2c_client *client = i2c_verify_client(dev);
>         int err;
>
> -      if (!client)
> +      if (!client || dev_pm_skip_suspend(dev))
>                 return 0;
>
>         err = pm_generic_suspend_late(&client->dev);
>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"
       [not found]                 ` <297191986.3285872.1644002564779@mail.yahoo.com>
@ 2022-02-11 17:51                   ` Wolfram Sang
  2022-03-02 23:20                     ` Alex Deucher
  0 siblings, 1 reply; 11+ messages in thread
From: Wolfram Sang @ 2022-02-11 17:51 UTC (permalink / raw)
  To: Tareque Md.Hanif
  Cc: Hsin-Yi Wang, linux-i2c, linux-kernel, amd-gfx, Bibby Hsieh,
	Marek Szyprowski, Matthias Brugger

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

On Fri, Feb 04, 2022 at 07:22:44PM +0000, Tareque Md.Hanif wrote:
>  The issue still exists. It takes very long time to suspend (10-12s). `DRI_PRIME=1 glxgears` is a black window.
> 
> journalctl attached
> Looking forward to any testing.

Any new ideas which Tareque could test?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"
  2022-02-11 17:51                   ` Wolfram Sang
@ 2022-03-02 23:20                     ` Alex Deucher
  0 siblings, 0 replies; 11+ messages in thread
From: Alex Deucher @ 2022-03-02 23:20 UTC (permalink / raw)
  To: Wolfram Sang, Tareque Md.Hanif, Hsin-Yi Wang, linux-i2c,
	linux-kernel, amd-gfx, Bibby Hsieh, Marek Szyprowski,
	Matthias Brugger

On Fri, Feb 11, 2022 at 12:51 PM Wolfram Sang <wsa@kernel.org> wrote:
>
> On Fri, Feb 04, 2022 at 07:22:44PM +0000, Tareque Md.Hanif wrote:
> >  The issue still exists. It takes very long time to suspend (10-12s). `DRI_PRIME=1 glxgears` is a black window.
> >
> > journalctl attached
> > Looking forward to any testing.
>
> Any new ideas which Tareque could test?

For some background, the GPU has multiple i2c buses attached to it
which the driver uses for querying the EDID on monitors over i2c.
Although in this case, the i2c buses are not used because there is no
display controller on this particular GPU.  I'm not even sure if the
gpu driver exposes any i2c buses in this case.  The i2c buses present
are in a vbios table that the driver parses at load time.  If there
are none on your platform, then it's probably not the AMD GPU driver.
Can you check if there are any i2c buses from the AMD GPU device in
sysfs?  I don't really see why this patch would change anything off
hand on the GPU.  Maybe the GPU is a red herring.  No one reported any
regressions on systems with AMD CPUs or even other Intel CPUs.  This
seems to be specific to a particular Intel CPU + AMD Topaz GPUs.  The
dGPU power is controlled by the platform via ACPI (it's usually a GPIO
under the covers).  I wonder if the issue is related to one of the i2c
buses or devices on the intel platform?  E.g.,

00:15.0 Signal processing controller: Intel Corporation Sunrise
Point-LP Serial IO I2C Controller #0 (rev 21)
00:15.1 Signal processing controller: Intel Corporation Sunrise
Point-LP Serial IO I2C Controller #1 (rev 21)
00:1f.4 SMBus: Intel Corporation Sunrise Point-LP SMBus (rev 21)

I'm not sure what those do, but maybe that is something to look at?

Also there are some PCI AERs in the kernel log.  Are those present
without the patch?

Alex

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"
       [not found] ` <5849ab287df1b06e141d87bbffdbcd627e999578.camel@yandex.ru>
@ 2022-01-07 18:35   ` Konstantin Kharlamov
  0 siblings, 0 replies; 11+ messages in thread
From: Konstantin Kharlamov @ 2022-01-07 18:35 UTC (permalink / raw)
  To: Tareque Md.Hanif, Konstantin Kharlamov, linux-kernel, amd-gfx,
	Bibby Hsieh, Marek Szyprowski, Hsin-Yi Wang, Matthias Brugger,
	Wolfram Sang

On Fri, 2022-01-07 at 21:20 +0300, Konstantin Kharlamov wrote:
> Thank you! I tested it (had to resolve a small conflict), works for me. So, in
> case you need it, the patch is
> 
>         Tested-by: Konstantin Kharlamov <hi-angel@yandex.ru>
> 
> By the way, shouldn't the patch include a field 
> 
>         Cc: <stable@vger.kernel.org> # 5.14+
> 
> ?
> 
> P.S.: sorry, for all mangled up CC fields. For some reason I didn't get your
> email, I found this patch in the archive. And the mbox that archive provides
> breaks all TO and CC fields, so I manually restored addresses that I have.

Restored the fields now, sorry, I found the mail, it was moved to another folder by a filter

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-03-02 23:50 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-06 12:24 [PATCH] Revert "i2c: core: support bus regulator controlling in adapter" Wolfram Sang
2022-01-07 20:28 ` Wolfram Sang
2022-01-12  9:32 ` Wolfram Sang
2022-01-12  9:51   ` Konstantin Kharlamov
     [not found]     ` <4dfbee97-14c2-718b-9cbd-fdeeace96f59@yahoo.com>
2022-01-12 10:58       ` Hsin-Yi Wang
2022-01-12 12:24         ` Hsin-Yi Wang
     [not found]         ` <6121a782-6927-f033-1c09-ffe4ad7700ae@yahoo.com>
2022-01-15 17:26           ` Hsin-Yi Wang
     [not found]             ` <363432688.323955.1642272250312@mail.yahoo.com>
2022-02-04 18:18               ` Hsin-Yi Wang
     [not found]                 ` <297191986.3285872.1644002564779@mail.yahoo.com>
2022-02-11 17:51                   ` Wolfram Sang
2022-03-02 23:20                     ` Alex Deucher
     [not found] <20220106122452.18719-1-wsa () kernel ! org>
     [not found] ` <5849ab287df1b06e141d87bbffdbcd627e999578.camel@yandex.ru>
2022-01-07 18:35   ` Konstantin Kharlamov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).