From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: "moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Devicetree List <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Ikjoon Jang <ikjn@chromium.org>
Subject: Re: [PATCH] arm64: dts: mt8173: Re-measure capacity-dmips-mhz
Date: Thu, 9 Jul 2020 02:55:26 +0800 [thread overview]
Message-ID: <CAJMQK-iGwXFwkvY_1nYiVQ6D-N5yU8YNqxeaSy-1XNMJHj1H0A@mail.gmail.com> (raw)
In-Reply-To: <71bc5fa2-0869-5d91-6bb8-e8d59176e19c@gmail.com>
On Thu, Jul 9, 2020 at 1:01 AM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
>
>
> On 06/07/2020 10:37, Hsin-Yi Wang wrote:
> > Re measure capacity-dmips-mhz on elm and hana:
> >
> > cpu 1: 9502 DMIPS @ 1703 Mhz
> > cpu 3: 16250 DMIPS @ 2106 Mhz
> >
> > ==> 740 : 1024
>
> I have some trouble to match the commit message to the actual patch. Commit
> message talks about cpu 1 but patch changes cpu0. Where are the values of the
> other CPUs?
Small cpu on 8173 is cpu0 & cpu1, while big cpu is cpu2 & cpu3.
Small cpu: 9502 DMIPS @ 1703 Mhz
Big cpu: 16250 DMIPS @ 2106 Mhz
9502/1703 : 16250/2106 = 740 : 1024 (scale big cpu to 1024), and this patch
changes the small cpu value to 740.
>
> Regards,
> Matthias
>
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 70b1ffcab7f0..5e046f9d48ce 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -167,7 +167,7 @@ cpu0: cpu@0 {
> > <&apmixedsys CLK_APMIXED_MAINPLL>;
> > clock-names = "cpu", "intermediate";
> > operating-points-v2 = <&cluster0_opp>;
> > - capacity-dmips-mhz = <526>;
> > + capacity-dmips-mhz = <740>;
> > };
> >
> > cpu1: cpu@1 {
> > @@ -182,7 +182,7 @@ cpu1: cpu@1 {
> > <&apmixedsys CLK_APMIXED_MAINPLL>;
> > clock-names = "cpu", "intermediate";
> > operating-points-v2 = <&cluster0_opp>;
> > - capacity-dmips-mhz = <526>;
> > + capacity-dmips-mhz = <740>;
> > };
> >
> > cpu2: cpu@100 {
> >
next prev parent reply other threads:[~2020-07-08 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 8:37 [PATCH] arm64: dts: mt8173: Re-measure capacity-dmips-mhz Hsin-Yi Wang
2020-07-08 17:01 ` Matthias Brugger
2020-07-08 18:55 ` Hsin-Yi Wang [this message]
2020-07-10 13:34 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJMQK-iGwXFwkvY_1nYiVQ6D-N5yU8YNqxeaSy-1XNMJHj1H0A@mail.gmail.com \
--to=hsinyi@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=ikjn@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).