From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Robert Foss <robert.foss@linaro.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Dongchun Zhu <dongchun.zhu@mediatek.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andrey Konovalov <andrey.konovalov@linaro.org>,
linux-media <linux-media@vger.kernel.org>,
Tomasz Figa <tfiga@chromium.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: ov8856: Set default mbus format but allow caller to alter
Date: Tue, 17 Aug 2021 18:32:33 +0800 [thread overview]
Message-ID: <CAJMQK-ixwkR2ECJdYXXtHJTGsSfV_Axs0-E1-rbS8e3XF92FLQ@mail.gmail.com> (raw)
In-Reply-To: <CAG3jFyuT09KOG9Xn-wbrr2DSOB=jSRvBVj96Vx4ja0PQWPKh6g@mail.gmail.com>
On Wed, Jul 28, 2021 at 7:22 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> Hey Hsin-Yi,
>
> Thanks for looking into this.
>
> On Mon, 5 Jul 2021 at 10:17, Hsin-Yi Wang <hsinyi@chromium.org> wrote:
> >
> > Setting the value of V_WIN_OFF (0x3818) from 0x02 to 0x01 to use GRBG
> > format still results in wrong color output if data is tuned in BGGR mode
> > before.
> >
> > Set default mbus format for the supported modes, but allow the caller of
> > set(get)_fmt to change the bayer format between BGGR and GRBG.
> >
> > Set the default mbus format for 3264x2448 (and 1632x1224) to BGGR as the
> > data sheet states the value of this reg should be 0x02 by default.
> >
> > If new modes are added in the future, they can add the
> > mipi_data_mbus_{format} settings into bayer_offset_configs to adjust their
> > offset regs.
> >
> > Fixes: 2984b0ddd557 ("media: ov8856: Configure sensor for GRBG Bayer for all modes")
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
<snip>
>
> Looks good to me.
>
> Reviewed-by: Robert Foss <robert.foss@linaro.org>
Hello maintainers,
kindly ping on this patch, thanks!
prev parent reply other threads:[~2021-08-17 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 8:17 [PATCH] media: ov8856: Set default mbus format but allow caller to alter Hsin-Yi Wang
2021-07-28 11:22 ` Robert Foss
2021-08-17 10:32 ` Hsin-Yi Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJMQK-ixwkR2ECJdYXXtHJTGsSfV_Axs0-E1-rbS8e3XF92FLQ@mail.gmail.com \
--to=hsinyi@chromium.org \
--cc=andrey.konovalov@linaro.org \
--cc=dongchun.zhu@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robert.foss@linaro.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).