linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: "Tareque Md.Hanif" <tarequemd.hanif@yahoo.com>
Cc: Wolfram Sang <wsa@kernel.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"
Date: Sat, 5 Feb 2022 02:18:18 +0800	[thread overview]
Message-ID: <CAJMQK-jx+z974AT_p+-AVAbMQQ33V-XU9NKmy-i6nbS5zagHBA@mail.gmail.com> (raw)
In-Reply-To: <363432688.323955.1642272250312@mail.yahoo.com>

On Sun, Jan 16, 2022 at 2:44 AM Tareque Md.Hanif
<tarequemd.hanif@yahoo.com> wrote:
>
> Hi Hsin-Yi,
>
> The issue still exists. I reverted a19f75de73c220b4496d2aefb7a605dd032f7c01 (the commit that reverted 5a7b95fb993ec399c8a685552aa6a8fc995c40bd) and manually applied the patch (tags/v5.16). journalctl attached.

hi Tareque,

Can you apply the same setting[1] again and with this patch to see if
the issue is still there?
https://github.com/torvalds/linux/commit/6dc8265f9803ccb7e5da804e01601f0c14f270e0

[1] reverted a19f75de73c220b4496d2aefb7a605dd032f7c01 (the commit that
reverted 5a7b95fb993ec399c8a685552aa6a8fc995c40bd) and manually
applied the patch (tags/v5.16)

Thanks
>
> Regards,
>
> Tareque
>
> On Saturday, January 15, 2022, 11:27:07 PM GMT+6, Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
>
> hi Tareque,
>
>
> On Fri, Jan 14, 2022 at 6:09 PM Tareque Md Hanif
> <tarequemd.hanif@yahoo.com> wrote:
> >
> > Hi Hsin-Yi,
> >
> > On 1/12/22 16:58, Hsin-Yi Wang wrote:
> >
> > Can you help provide logs if we apply
> > 5a7b95fb993ec399c8a685552aa6a8fc995c40bd but revert
> > 8d35a2596164c1c9d34d4656fd42b445cd1e247f?
> >
> > Issue still exists. journalctl log attached in revert_8d.txt
> >
> >
> > > after apply 5a7b95fb993ec399c8a685552aa6a8fc995c40bd
> > > 1. delete SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late,
> > > i2c_resume_early) and function i2c_suspend_late() and
> > > i2c_resume_early().
> >
> > No issues. journalctl log attached in test1.txt
> >
> >
> > > 2. delete SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume,
> > > NULL) and function i2c_runtime_suspend() and i2c_runtime_resume().
> >
> > Issue exists. journalctl log attached in test2.txt
>
>
> Thanks for the testing.
> Can you help us test if applying the following patch on top of
> 5a7b95fb993ec399c8a685552aa6a8fc995c40bd works? Thanks
>
> diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
> index 9eb4009cb250..6b046012aa08 100644
> --- a/drivers/i2c/i2c-core-base.c
> +++ b/drivers/i2c/i2c-core-base.c
> @@ -484,7 +484,7 @@ static int i2c_resume_early(struct device *dev)
>         struct i2c_client *client = i2c_verify_client(dev);
>         int err;
>
> -      if (!client)
> +      if (!client || dev_pm_skip_resume(dev))
>                 return 0;
>
>         if (pm_runtime_status_suspended(&client->dev) &&
> @@ -502,7 +502,7 @@ static int i2c_suspend_late(struct device *dev)
>         struct i2c_client *client = i2c_verify_client(dev);
>         int err;
>
> -      if (!client)
> +      if (!client || dev_pm_skip_suspend(dev))
>                 return 0;
>
>         err = pm_generic_suspend_late(&client->dev);
>

  parent reply	other threads:[~2022-02-04 18:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06 12:24 Wolfram Sang
2022-01-07 20:28 ` Wolfram Sang
2022-01-12  9:32 ` Wolfram Sang
2022-01-12  9:51   ` Konstantin Kharlamov
     [not found]     ` <4dfbee97-14c2-718b-9cbd-fdeeace96f59@yahoo.com>
2022-01-12 10:58       ` Hsin-Yi Wang
2022-01-12 12:24         ` Hsin-Yi Wang
     [not found]         ` <6121a782-6927-f033-1c09-ffe4ad7700ae@yahoo.com>
2022-01-15 17:26           ` Hsin-Yi Wang
     [not found]             ` <363432688.323955.1642272250312@mail.yahoo.com>
2022-02-04 18:18               ` Hsin-Yi Wang [this message]
     [not found]                 ` <297191986.3285872.1644002564779@mail.yahoo.com>
2022-02-11 17:51                   ` Wolfram Sang
2022-03-02 23:20                     ` Alex Deucher
     [not found] <20220106122452.18719-1-wsa () kernel ! org>
     [not found] ` <5849ab287df1b06e141d87bbffdbcd627e999578.camel@yandex.ru>
2022-01-07 18:35   ` Konstantin Kharlamov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJMQK-jx+z974AT_p+-AVAbMQQ33V-XU9NKmy-i6nbS5zagHBA@mail.gmail.com \
    --to=hsinyi@chromium.org \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bibby.hsieh@mediatek.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=matthias.bgg@gmail.com \
    --cc=tarequemd.hanif@yahoo.com \
    --cc=wsa@kernel.org \
    --subject='Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).