From: Pascal Giard <pascal.giard@etsmtl.ca>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Sanjay Govind <sanjay.govind9@gmail.com>
Subject: Re: [PATCH v2] HID: sony: support for ghlive ps3/wii u dongles
Date: Wed, 25 Nov 2020 10:06:03 -0500 [thread overview]
Message-ID: <CAJNNDm=2mh43JxrLkpPM6Nuag-9d1acyQH=uwJyQzxOy-gO8rA@mail.gmail.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2011251439500.3441@cbobk.fhfr.pm>
Apologies for the resend. I had not realized that gmail's app for
smartphones didn't really support plaintext.
On Wed, Nov 25, 2020 at 8:41 AM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Wed, 25 Nov 2020, Pascal.Giard@etsmtl.ca wrote:
>
> > Thank you for reviewing this new version.
> >
> > You are right, we could totally do without GHL_GUITAR_CONTROLLER.
> >
> > This can be seen as premature generalization or an excess of optimism;
> > I'm assuming that the PS4 also needs magic control messages to behave
> > correctly, and that I will figure those sooner than later. But I may be
> > assuming too much and this will be trivial to add when the time comes.
>
> Yeah, let's extend this only when really needed.
Fair.
> > Do you want me to submit a v3?
>
> Please do, thanks. I'll merge that one, I promise :) Sorry for not
> having catched this in v1 already.
No worries, will do.
Thanks again!
-Pascal
next prev parent reply other threads:[~2020-11-25 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <acf595c3-1b0a-4d73-8087-784d89bdec91@email.android.com>
2020-11-25 13:40 ` [PATCH v2] HID: sony: support for ghlive ps3/wii u dongles Jiri Kosina
2020-11-25 15:06 ` Pascal Giard [this message]
2020-10-09 2:27 [PATCH] HID: ghlive: " Pascal Giard
2020-11-08 1:38 ` [PATCH v2] HID: sony: " Pascal Giard
2020-11-25 13:24 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJNNDm=2mh43JxrLkpPM6Nuag-9d1acyQH=uwJyQzxOy-gO8rA@mail.gmail.com' \
--to=pascal.giard@etsmtl.ca \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanjay.govind9@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).