From: "Turquette, Mike" <mturquette@ti.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org,
Linux PM list <linux-pm@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Kevin Hilman <khilman@ti.com>,
myungjoo.ham@gmail.com
Subject: Re: [PATCH 2/2] PM / devfreq: fixed syntax errors.
Date: Wed, 11 Jan 2012 16:21:59 -0800 [thread overview]
Message-ID: <CAJOA=zOX0X9M2Lqu1GQC3o37V7e-jja7KbHteJ+yDWL-JRf5YA@mail.gmail.com> (raw)
In-Reply-To: <1326276130-4042-2-git-send-email-myungjoo.ham@samsung.com>
On Wed, Jan 11, 2012 at 2:02 AM, MyungJoo Ham <myungjoo.ham@samsung.com> wrote:
> If devfreq.h was included without CONFIG_PM_DEVFREQ, there has been a
> compiler error with an additional semicolon added. This patch removes
> that errorneous semicolon.
Looks good.
Reviewed-by: Mike Turquette <mturquette@ti.com>
>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> include/linux/devfreq.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
> index e9385bf..5862475 100644
> --- a/include/linux/devfreq.h
> +++ b/include/linux/devfreq.h
> @@ -205,12 +205,12 @@ struct devfreq_simple_ondemand_data {
> static struct devfreq *devfreq_add_device(struct device *dev,
> struct devfreq_dev_profile *profile,
> struct devfreq_governor *governor,
> - void *data);
> + void *data)
> {
> return NULL;
> }
>
> -static int devfreq_remove_device(struct devfreq *devfreq);
> +static int devfreq_remove_device(struct devfreq *devfreq)
> {
> return 0;
> }
> --
> 1.7.4.1
>
next prev parent reply other threads:[~2012-01-12 0:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 10:02 [PATCH 1/2] PM / devfreq: add min/max_freq limit requested by users MyungJoo Ham
2012-01-11 10:02 ` [PATCH 2/2] PM / devfreq: fixed syntax errors MyungJoo Ham
2012-01-12 0:21 ` Turquette, Mike [this message]
2012-01-11 22:54 ` [PATCH 1/2] PM / devfreq: add min/max_freq limit requested by users Rafael J. Wysocki
2012-01-12 1:51 ` MyungJoo Ham
2012-01-12 0:20 ` Turquette, Mike
2012-01-12 2:08 ` MyungJoo Ham
2012-01-13 4:47 ` mark gross
2012-01-17 10:32 ` MyungJoo Ham
2012-01-18 3:27 ` mark gross
2012-01-19 5:05 ` MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJOA=zOX0X9M2Lqu1GQC3o37V7e-jja7KbHteJ+yDWL-JRf5YA@mail.gmail.com' \
--to=mturquette@ti.com \
--cc=khilman@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).