From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932297AbcHPUGb (ORCPT ); Tue, 16 Aug 2016 16:06:31 -0400 Received: from mail-ua0-f170.google.com ([209.85.217.170]:33116 "EHLO mail-ua0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932206AbcHPUGY (ORCPT ); Tue, 16 Aug 2016 16:06:24 -0400 MIME-Version: 1.0 In-Reply-To: <665a9824-b0c5-9eb3-d4b6-4821204d5db0@osg.samsung.com> References: <20160601231533.9354-1-stephen.boyd@linaro.org> <20160601231533.9354-18-stephen.boyd@linaro.org> <665a9824-b0c5-9eb3-d4b6-4821204d5db0@osg.samsung.com> From: Stephen Boyd Date: Tue, 16 Aug 2016 13:06:03 -0700 Message-ID: Subject: Re: [PATCH 17/34] clk: maxgen: Migrate to clk_hw based OF and registration APIs To: Javier Martinez Canillas Cc: Javier Martinez Canillas , Michael Turquette , Stephen Boyd , Linux Kernel , "linux-arm-kernel@lists.infradead.org" , linux-clk@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 7, 2016 at 11:55 AM, Javier Martinez Canillas wrote: > On 06/07/2016 02:50 PM, Javier Martinez Canillas wrote: >> Hello Stephen, >> >> On Wed, Jun 1, 2016 at 7:15 PM, Stephen Boyd wrote: >>> Now that we have clk_hw based provider APIs to register clks, we >>> can get rid of struct clk pointers while registering clks in >>> these drivers, allowing us to move closer to a clear split of >>> consumer and provider clk APIs. >>> >>> Cc: Javier Martinez Canillas >> >> This email address doesn't exist anymore, you can use >> javier@osg.samsung.com instead. >> >>> Signed-off-by: Stephen Boyd >>> --- >>> >>> See commit 58657d189a2f and it's children for details on this >>> new registration API. >>> >> >> I tried this patch on top of linux-next and my Peach Pi Chromebook >> (that has a max77802 chip) failed to boot. Following is the relevant >> parts from the boot log: >> > > It seems the mailer did a mess with the line wrapping so here's another attempt: > Thanks! Found the problem too. ----8<----- diff --git a/drivers/clk/clk-max-gen.c b/drivers/clk/clk-max-gen.c index 4bb53fcf8639..5e8bac190698 100644 --- a/drivers/clk/clk-max-gen.c +++ b/drivers/clk/clk-max-gen.c @@ -169,7 +169,7 @@ int max_gen_clk_probe(struct platform_device *pdev, struct regmap *regmap, if (dev->of_node) { ret = of_clk_add_hw_provider(dev->of_node, of_clk_max_gen_get, - max_gen_clks); + max_gen_data); if (ret) { dev_err(dev, "failed to register OF clock provider\n"); return ret;