From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754106Ab2GRLmQ (ORCPT ); Wed, 18 Jul 2012 07:42:16 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:58546 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752594Ab2GRLmM (ORCPT ); Wed, 18 Jul 2012 07:42:12 -0400 MIME-Version: 1.0 In-Reply-To: <20120717150928.GB11587@redhat.com> References: <1342169711-12386-1-git-send-email-asias@redhat.com> <20120717150928.GB11587@redhat.com> Date: Wed, 18 Jul 2012 12:42:09 +0100 Message-ID: Subject: Re: [PATCH RESEND 0/5] Add vhost-blk support From: Stefan Hajnoczi To: "Michael S. Tsirkin" Cc: Asias He , Jens Axboe , linux-aio@kvack.org, target-devel , linux-scsi , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, lf-virt , James Bottomley , Anthony Liguori , Jeff Moyer , Benjamin LaHaise , Alexander Viro , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Zhi Yong Wu , Christoph Hellwig , Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 17, 2012 at 4:09 PM, Michael S. Tsirkin wrote: > On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote: >> >> Hi folks, >> >> [I am resending to fix the broken thread in the previous one.] >> >> This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk >> device accelerator. Compared to userspace virtio-blk implementation, vhost-blk >> gives about 5% to 15% performance improvement. > > Same thing as tcm_host comment: > > It seems not 100% clear whether this driver will have major > userspace using it. And if not, it would be very hard to support a > driver when recent userspace does not use it in the end. > > I think a good idea for 3.6 would be to make it depend on > CONFIG_STAGING. Then we don't commit to an ABI. For this, you can add > a separate Kconfig and source it from drivers/staging/Kconfig. Maybe it > needs to be in a separate directory drivers/vhost/staging/Kconfig. > > I Cc'd the list of tcm_host in the hope that you can cooperate on this. > Adding it to staging allows more people to try it out, so that's a good thing. If I get a moment to play with it I'll let you know the results. Stefan