From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0DCCC4332F for ; Thu, 9 Dec 2021 17:41:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239585AbhLIRog (ORCPT ); Thu, 9 Dec 2021 12:44:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236876AbhLIRo3 (ORCPT ); Thu, 9 Dec 2021 12:44:29 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAF35C061746 for ; Thu, 9 Dec 2021 09:40:55 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id c32so13471553lfv.4 for ; Thu, 09 Dec 2021 09:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=zJn8EMJ3bNTEj0rup3ByEhFgEv6FqrmSjpgYx9Y6/fs=; b=THwfLzEETO2LotDmBtfbO7GVo9RpDWd/aau1pNnNfsL6iDlKF9rpdpO1h3BsBtGnhA oNeqsvZXCU1qeXPhTr4vG+yWl6NMh8+Wsfo7HT50hxY+ZjFl3uYp4t18U4MpPo4ln7eZ SxdNiF7oQN9JM2NE+8KH++oZIRxEumMj/LFAE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=zJn8EMJ3bNTEj0rup3ByEhFgEv6FqrmSjpgYx9Y6/fs=; b=gDWpCWnzV56O+yQG8IDh08tMG22uodrmsBYuC40LA0nv3kcJN9wbtjIe20m3ufwzAZ 7GPSvS0N1rQmq9OO9HQUlz+JiY/lQDBDEO0yLH7khWjhcr+895TIoMhfHsX8nokQnXXW Dzjz1cMmE1HmDPc4o7oykFP3EqkWaUmiO7pkP8o32KLoLtYVgVRUSe1rGPFnsjhZMo8m 5FOvKyMSMc7CNicY8TetmnLaMSNP3CbC7QTa+oDgqJ9Ea/Lcn1/fEAiz7/01UgwLw0N8 9BYnXe58OCnGKjHQFV8Zcy3lbJminSSjiZ1jO0dx8kg0kqrs1Q8rvG3ev8djbdnJjV+u LcEQ== X-Gm-Message-State: AOAM531rpQUDTJlK2TKPAaMRg7znYpS0nUwPAOHbjWvmGBcJqkvyjFeU 61qBy/CRh+2dg12ywRzYgQlQQWeWGXd0IquYOXEvQA== X-Google-Smtp-Source: ABdhPJxRc2UmoPypurDhZ/h36kJMpMBzWRNG3CHeSoDYXQgKpHDaTngOxX39repphKbLrvMBnrfWmkuPkEZQBYrwrUQ= X-Received: by 2002:a05:6512:1510:: with SMTP id bq16mr6888001lfb.628.1639071654062; Thu, 09 Dec 2021 09:40:54 -0800 (PST) MIME-Version: 1.0 References: <20211027162806.2014022-1-markyacoub@chromium.org> In-Reply-To: From: Mark Yacoub Date: Thu, 9 Dec 2021 12:40:43 -0500 Message-ID: Subject: Re: [PATCH] drm/mediatek: Set the default value of rotation to DRM_MODE_ROTATE_0 To: Chun-Kuang Hu Cc: Sean Paul , Mark Yacoub , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , DRI Development , "moderated list:ARM/Mediatek SoC support" , Linux ARM , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 8, 2021 at 7:16 PM Chun-Kuang Hu wrot= e: > > Hi Mark: > > Mark Yacoub =E6=96=BC 2021=E5=B9=B410=E6=9C=882= 8=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8A=E5=8D=8812:28=E5=AF=AB=E9=81=93=EF= =BC=9A > > > > From: Mark Yacoub > > > > At the reset hook, call __drm_atomic_helper_plane_reset which is > > called at the initialization of the plane and sets the default value of > > rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1. > > This patch looks good to me, but please fix this checkpatch warning: Uploaded a new revision. Thanks! > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Mark > Yacoub ' !=3D 'Signed-off-by: Mark Yacoub > ' > > total: 0 errors, 1 warnings, 11 lines checked > > Regards, > Chun-Kuang. > > > > > Tested on Jacuzzi (MTK). > > Resolves IGT@kms_properties@plane-properties-{legacy,atomic} > > > > Signed-off-by: Mark Yacoub > > --- > > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm= /mediatek/mtk_drm_plane.c > > index e6dcb34d30522..accd26481b9fb 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > > @@ -44,9 +44,10 @@ static void mtk_plane_reset(struct drm_plane *plane) > > state =3D kzalloc(sizeof(*state), GFP_KERNEL); > > if (!state) > > return; > > - plane->state =3D &state->base; > > } > > > > + __drm_atomic_helper_plane_reset(plane, &state->base); > > + > > state->base.plane =3D plane; > > state->pending.format =3D DRM_FORMAT_RGB565; > > } > > -- > > 2.33.0.1079.g6e70778dc9-goog > >