From: Joel Fernandes <joelaf@google.com>
To: Alessio Balsini <balsini@android.com>
Cc: "open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>,
dvander@gmail.com, Yifan Hong <elsk@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Cc: Android Kernel" <kernel-team@android.com>
Subject: Re: [PATCH] loop: Add LOOP_SET_DIRECT_IO in compat ioctl
Date: Tue, 6 Aug 2019 20:10:05 -0400 [thread overview]
Message-ID: <CAJWu+oo=GrZ+SbA6=bboM4==TKXBsTRWkTrkWiZ55pqhJtgQqQ@mail.gmail.com> (raw)
In-Reply-To: <20190806235708.GA10161@google.com>
On Tue, Aug 6, 2019 at 7:57 PM Alessio Balsini <balsini@android.com> wrote:
>
> Hi Joel,
>
> I was considering the rationale for this patch totally straightforward:
> it enables Direct I/O ioctl to 32 bit processes running on 64 bit
> systems for compatibility reasons, as for all the other lo_compat_ioctl
> commands.
> Also the reason why someone would decide to use Direct I/O with loop
> devices is well known, that is why the feature exists :) So I thought
> this was another redundant information to put in the commit message and
> decided to omit it.
No objections from me if maintainers are Ok with it.
> If you still think that I should update the commit message with this
> information, I will do so.
I think you should.
thanks,
- Joel
next prev parent reply other threads:[~2019-08-07 0:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 22:05 [PATCH] loop: Add LOOP_SET_DIRECT_IO in compat ioctl Alessio Balsini
2019-08-06 22:25 ` Joel Fernandes
2019-08-06 23:57 ` Alessio Balsini
2019-08-07 0:10 ` Joel Fernandes [this message]
2019-08-07 0:48 ` [PATCH v2] loop: Add LOOP_SET_DIRECT_IO to " Alessio Balsini
2019-08-08 23:51 ` Joel Fernandes
2019-08-09 3:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJWu+oo=GrZ+SbA6=bboM4==TKXBsTRWkTrkWiZ55pqhJtgQqQ@mail.gmail.com' \
--to=joelaf@google.com \
--cc=axboe@kernel.dk \
--cc=balsini@android.com \
--cc=dvander@gmail.com \
--cc=elsk@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).