From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754226AbdJSPmc (ORCPT ); Thu, 19 Oct 2017 11:42:32 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:47232 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752586AbdJSPmb (ORCPT ); Thu, 19 Oct 2017 11:42:31 -0400 X-Google-Smtp-Source: ABhQp+T+sygGc3CRfU5kTHIdvFmsqeHIJSPeEdZboW2RKaHSrCYgImoyI8ZyWZeKxyL5bGhO25RP+rrfw/SNqfgYIWQ= MIME-Version: 1.0 In-Reply-To: <20171019083230.2450779-1-arnd@arndb.de> References: <20171019083230.2450779-1-arnd@arndb.de> From: Joel Fernandes Date: Thu, 19 Oct 2017 08:42:28 -0700 Message-ID: Subject: Re: [PATCH] tracing: always define trace_{irq,preempt}_{enable_disable} To: Arnd Bergmann Cc: Steven Rostedt , Ingo Molnar , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Thu, Oct 19, 2017 at 1:32 AM, Arnd Bergmann wrote: > We get a build error in the irqsoff tracer in some configurations: > > kernel/trace/trace_irqsoff.c: In function 'trace_preempt_on': > kernel/trace/trace_irqsoff.c:855:2: error: implicit declaration of function 'trace_preempt_enable_rcuidle'; did you mean 'trace_irq_enable_rcuidle'? [-Werror=implicit-function-declaration] > trace_preempt_enable_rcuidle(a0, a1); > > The problem is that trace_preempt_enable_rcuidle() has different > definition based on multiple Kconfig symbols, but not all combinations > have a valid definition. > > This changes the conditions so that we always get exactly one > definition of each of the four tracing macros. I have not tried > to verify that these definitions are sensible, but now we > can build all randconfig combinations again. > Thanks for catching this. I didn't follow why it breaks for you, especially I'm troubled by your proposal of defining the empty macro for !defined(CONFIG_DEBUG_PREEMPT) in your patch. Could you provide your config sample and architecture you're building for? I'm guessing its ARM but let me know. I will try to build it and reproduce it. thanks, Joel