From: Joel Fernandes <joelaf@google.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zilstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v1 1/2] tracing: Improve design of preemptirq tracepoints and its users
Date: Thu, 15 Mar 2018 13:19:54 -0700 [thread overview]
Message-ID: <CAJWu+oqsDT28t_2=dUcjrid=0S3dLzM-Y2YrpYJWc-RoQKJBxg@mail.gmail.com> (raw)
In-Reply-To: <201803160351.YXuH1FAL%fengguang.wu@intel.com>
Hello,
On Thu, Mar 15, 2018 at 12:51 PM, kbuild test robot <lkp@intel.com> wrote:
>
> Hi Joel,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.16-rc5 next-20180315]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Joel-Fernandes/tracing-Improve-design-of-preemptirq-tracepoints-and-its-users/20180316-012211
> config: i386-randconfig-x006-201810 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
> kernel//locking/lockdep.c: In function 'lockdep_init':
> >> kernel//locking/lockdep.c:4325:2: error: implicit declaration of function 'register_trace_irq_disable'; did you mean 'trace_irq_disable'? [-Werror=implicit-function-declaration]
> register_trace_irq_disable(lockdep_hardirqs_off, NULL);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
The reason for this is PREEMPTIRQ_TRACEPOINTS depends on FTRACE which
is turned off in the config. Its a combination I hadn't tested in my
matrix. It causes build errors in in lockdep code that tries to
register the lockdep hooks. I'll fix it in the next rev. Thanks.
- Joel
next prev parent reply other threads:[~2018-03-15 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 21:43 [PATCH v1 0/2] Improve preemptirq tracepoint usage Joel Fernandes
2018-03-13 21:43 ` [PATCH v1 1/2] tracing: Improve design of preemptirq tracepoints and its users Joel Fernandes
2018-03-15 19:51 ` kbuild test robot
2018-03-15 20:19 ` Joel Fernandes [this message]
2018-03-16 3:13 ` kbuild test robot
2018-03-16 3:28 ` Joel Fernandes
2018-03-16 8:22 ` [tracing] b648360016: WARNING:at_kernel/locking/lockdep.c:#check_flags kernel test robot
2018-03-13 21:43 ` [PATCH v1 2/2] tracepoint: Prevent false-positive lockdep warnings Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJWu+oqsDT28t_2=dUcjrid=0S3dLzM-Y2YrpYJWc-RoQKJBxg@mail.gmail.com' \
--to=joelaf@google.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).