From: Joel Fernandes <joelaf@google.com>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Laurent Dufour <ldufour@linux.ibm.com>,
Suren Baghdasaryan <surenb@google.com>
Subject: Silencing false lockdep warning related to seq lock
Date: Fri, 14 May 2021 10:52:31 -0400 [thread overview]
Message-ID: <CAJWu+orW9PA7m_s5LHhQv-bEO0xFq7n+9-fznd79boKkmQUR6g@mail.gmail.com> (raw)
Hi Boqun,
You might have worked on such issues so I thought you're a good person to ask.
After apply Laurent's SPF patchset [1] , we're facing a large number
of (seemingly false positive) lockdep reports which are related to
circular dependencies with seq locks.
lock(A); write_seqcount(B)
vs.
write_seqcount(B); lock(A)
This cannot deadlock obviously. My current strategy which I hate is to
make it a raw seqcount write which bypasses lockdep. That's horrible
for obvious reasons. Do you have any tricks/patches up your sleeve to
silence these?
I suppose we still want to catch lockdep issues of the form (which
peterz chatted to me about):
lock(A); write_seqcount(B)
vs.
read_seqcount(B); lock(A)
which seems like it can deadlock.
I would rather make lockdep useful to catch these and not miss out on
them. Let me know what you think?
Cheers,
-Joel
[1] https://lkml.org/lkml/2019/4/16/615
next reply other threads:[~2021-05-14 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 14:52 Joel Fernandes [this message]
2021-05-17 4:21 ` Silencing false lockdep warning related to seq lock Boqun Feng
2021-05-18 1:52 ` Joel Fernandes
2021-05-18 2:24 ` Boqun Feng
2021-05-18 15:53 ` Joel Fernandes
2021-05-19 4:50 ` Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJWu+orW9PA7m_s5LHhQv-bEO0xFq7n+9-fznd79boKkmQUR6g@mail.gmail.com \
--to=joelaf@google.com \
--cc=boqun.feng@gmail.com \
--cc=joel@joelfernandes.org \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).