From: Joel Fernandes <joelaf@google.com>
To: Qais Yousef <qais.yousef@arm.com>
Cc: Doug Anderson <dianders@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
hsinyi@chromium.org, Nicolas Boichat <drinkcat@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Quentin Perret <qperret@google.com>,
ctheegal@codeaurora.org, Guenter Roeck <groeck@chromium.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cros_ec_spi: Even though we're RT priority, don't bump cpu freq
Date: Wed, 24 Jun 2020 13:55:02 -0400 [thread overview]
Message-ID: <CAJWu+oreQRCAkBhNQ-n6BPjYsdOL074ff8551sF3r7OxsseEVQ@mail.gmail.com> (raw)
In-Reply-To: <20200624175236.nblndmg6dfq2vr2u@e107158-lin.cambridge.arm.com>
On Wed, Jun 24, 2020 at 1:52 PM Qais Yousef <qais.yousef@arm.com> wrote:
>
> On 06/24/20 13:35, Joel Fernandes wrote:
>
> [...]
>
> > > Doing the in-kernel opt-out via API should be fine, I think. But this will
> > > need to be discussed in the wider circle. It will already clash with this for
> > > example
> > >
> > > https://lore.kernel.org/lkml/20200619172011.5810-1-qais.yousef@arm.com/
> >
> > Have not yet looked closer at that patch, but are you saying this
> > patch clashes with that work? Sorry I am operating on 2 hours of sleep
> > here.
>
> The series is an optimization to remove the uclamp overhead from the scheduler
> fastpath until the userspace uses it. It introduces a static key that is
> disabled by default and will cause uclamp logic not to execute in the fast
> path. Once the userspace starts using util clamp, which we detect by either
>
> 1. Changing uclamp value of a task with sched_setattr()
> 2. Modifying the default sysctl_sched_util_clamp_{min, max}
> 3. Modifying the default cpu.uclamp.{min, max} value in cgroup
>
> If we start having in-kernel users changing uclamp value this means drivers
> will cause the system to opt-in into uclamp automatically even if the
> userspace doesn't actually use it.
>
> I think we can solve this by providing a special API to opt-out safely. Which
> is the right thing to do anyway even if we didn't have this clash.
Makes sense, thanks.
- Joel
next prev parent reply other threads:[~2020-06-24 17:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 22:18 [PATCH] cros_ec_spi: Even though we're RT priority, don't bump cpu freq Douglas Anderson
2020-06-11 11:03 ` Quentin Perret
2020-06-11 17:48 ` Doug Anderson
2020-06-12 9:24 ` Quentin Perret
2020-06-12 12:34 ` Qais Yousef
2020-06-12 13:47 ` Quentin Perret
2020-06-12 14:00 ` Qais Yousef
2020-06-18 21:31 ` Doug Anderson
2020-06-19 15:31 ` Qais Yousef
2020-06-22 18:19 ` Doug Anderson
2020-06-23 15:56 ` Qais Yousef
2020-06-12 12:52 ` Qais Yousef
2020-06-18 21:18 ` Doug Anderson
2020-06-19 15:38 ` Qais Yousef
2020-06-22 18:21 ` Doug Anderson
2020-06-23 16:40 ` Qais Yousef
2020-06-24 15:49 ` Joel Fernandes
2020-06-24 16:55 ` Qais Yousef
2020-06-24 17:35 ` Joel Fernandes
2020-06-24 17:52 ` Qais Yousef
2020-06-24 17:55 ` Joel Fernandes [this message]
2020-06-24 18:29 ` Doug Anderson
2020-06-25 14:20 ` Qais Yousef
2020-06-24 16:01 ` Peter Zijlstra
2020-06-24 17:14 ` Qais Yousef
2020-06-24 15:56 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJWu+oreQRCAkBhNQ-n6BPjYsdOL074ff8551sF3r7OxsseEVQ@mail.gmail.com \
--to=joelaf@google.com \
--cc=bleung@chromium.org \
--cc=ctheegal@codeaurora.org \
--cc=dianders@chromium.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=hsinyi@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=qperret@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).