From: Gioh Kim <gi-oh.kim@ionos.com>
To: Jinpu Wang <jinpu.wang@ionos.com>
Cc: open list <linux-kernel@vger.kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Dan Williams <dan.j.williams@intel.com>,
laniel_francis@privacyrequired.com,
Kees Cook <keescook@chromium.org>, Daniel Axtens <dja@axtens.net>,
Andrew Morton <akpm@linux-foundation.org>,
Haris Iqbal <haris.iqbal@ionos.com>
Subject: Re: [PATCH v4] lib/string: Introduce sysfs_streqcase
Date: Thu, 8 Apr 2021 16:52:02 +0200 [thread overview]
Message-ID: <CAJX1Yta1nd-xMwzsFvk50RzWY_6CMbgfE-LH-SCQvPGdxDJ8pQ@mail.gmail.com> (raw)
In-Reply-To: <CAMGffEkPRJ1vBi7+bbejS+Acttt269DjW9M6P8n=5xVZ50aGXg@mail.gmail.com>
On Thu, Apr 8, 2021 at 3:14 PM Jinpu Wang <jinpu.wang@ionos.com> wrote:
>
> On Thu, Apr 8, 2021 at 3:06 PM Gioh Kim <gi-oh.kim@ionos.com> wrote:
> >
> > As the name shows, it checks if strings are equal in case insensitive
> > manner.
> >
> > For example, drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c uses
> > strncasecmp to check that the input via sysfs is "mi". But it would
> > work even-if the input is "min-wrongcommand".
> >
> > I found some more cases using strncasecmp to check the entire string
> > such as rtrs-clt-sysfs.c does. drivers/pnp/interface.c checks
> > "disable" command with strncasecmp but it would also work if the
> > command is "disable-wrong".
> >
> > Signed-off-by: Gioh Kim <gi-oh.kim@ionos.com>
> you should add the
> Reported-by: kernel test robot <lkp@intel.com>
> > ---
> you can add the changelog here after the ---
> v4->v3: removed #ifdef CONFIG_SYSFS ~ #endif.
>
> The string comparison doesn't depends on CONFIG_SYSFS at all.
>
> It looks good to me.
> Reviewed-by: Jack Wang <jinpu.wang@ionos.com>
>
>
Yes, I got two build error reports for v3.
Should I send v5 including "Reported-by: kernel test robot <lkp@intel.com>" tag?
next prev parent reply other threads:[~2021-04-08 14:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 13:06 [PATCH v4] lib/string: Introduce sysfs_streqcase Gioh Kim
2021-04-08 13:13 ` Jinpu Wang
2021-04-08 14:52 ` Gioh Kim [this message]
2021-04-08 18:16 ` Nick Desaulniers
2021-04-09 5:05 ` Andrew Morton
2021-04-09 6:44 ` Greg Kroah-Hartman
2021-04-09 6:51 ` Andrew Morton
2021-04-09 6:59 ` Greg Kroah-Hartman
[not found] ` <CAHp75VcjNWycV-SLUzzfgtMp8BzXUiUAoz_BYr4+nCazAzsrqw@mail.gmail.com>
2021-04-09 12:41 ` Gioh Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJX1Yta1nd-xMwzsFvk50RzWY_6CMbgfE-LH-SCQvPGdxDJ8pQ@mail.gmail.com \
--to=gi-oh.kim@ionos.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dja@axtens.net \
--cc=haris.iqbal@ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=keescook@chromium.org \
--cc=laniel_francis@privacyrequired.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).