[PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

[PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

[chris.chiu]

From: Chris Chiu <chris.chiu@canonical.com>

The .callback of the quirk for Sony VPCEH3U1E was unintetionally
removed by the commit 25417185e9b5 ("ACPI: video: Add DMI quirk
for GIGABYTE GB-BXBT-2807"). Add it back to make sure the quirk
for Sony VPCEH3U1E works as expected.

Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
Reported-by: Pavel Machek <pavel@ucw.cz>
---
 drivers/acpi/video_detect.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 811d298637cb..83cd4c95faf0 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -147,6 +147,7 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
 		},
 	},
 	{
+	.callback = video_detect_force_vendor,
 	.ident = "Sony VPCEH3U1E",
 	.matches = {
 		DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
-- 
2.20.1

Re: [PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

On Fri 2021-03-12 11:24:30, chris.chiu@canonical.com wrote:
> From: Chris Chiu <chris.chiu@canonical.com>
> 
> The .callback of the quirk for Sony VPCEH3U1E was unintetionally
> removed by the commit 25417185e9b5 ("ACPI: video: Add DMI quirk
> for GIGABYTE GB-BXBT-2807"). Add it back to make sure the quirk
> for Sony VPCEH3U1E works as expected.
> 
> Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
> Reported-by: Pavel Machek <pavel@ucw.cz>

Thanks for doing this.

Reviewed-by: Pavel Machek (CIP) <pavel@denx.de>

Best regards,						Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

[Rafael J. Wysocki]

On Sat, Mar 13, 2021 at 11:27 AM Pavel Machek <pavel@ucw.cz> wrote:
>
> On Fri 2021-03-12 11:24:30, chris.chiu@canonical.com wrote:
> > From: Chris Chiu <chris.chiu@canonical.com>
> >
> > The .callback of the quirk for Sony VPCEH3U1E was unintetionally
> > removed by the commit 25417185e9b5 ("ACPI: video: Add DMI quirk
> > for GIGABYTE GB-BXBT-2807"). Add it back to make sure the quirk
> > for Sony VPCEH3U1E works as expected.
> >
> > Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
> > Reported-by: Pavel Machek <pavel@ucw.cz>
>
> Thanks for doing this.
>
> Reviewed-by: Pavel Machek (CIP) <pavel@denx.de>

Applied as 5.12-rc5 material, thanks!

Re: [PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

On Fri 2021-03-19 17:44:32, Rafael J. Wysocki wrote:
> On Sat, Mar 13, 2021 at 11:27 AM Pavel Machek <pavel@ucw.cz> wrote:
> >
> > On Fri 2021-03-12 11:24:30, chris.chiu@canonical.com wrote:
> > > From: Chris Chiu <chris.chiu@canonical.com>
> > >
> > > The .callback of the quirk for Sony VPCEH3U1E was unintetionally
> > > removed by the commit 25417185e9b5 ("ACPI: video: Add DMI quirk
> > > for GIGABYTE GB-BXBT-2807"). Add it back to make sure the quirk
> > > for Sony VPCEH3U1E works as expected.
> > >
> > > Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
> > > Reported-by: Pavel Machek <pavel@ucw.cz>
> >
> > Thanks for doing this.
> >
> > Reviewed-by: Pavel Machek (CIP) <pavel@denx.de>
> 
> Applied as 5.12-rc5 material, thanks!

Commit 25417185e9b5 made it into stable, so this one should be Cc:
stable as well. Sorry for noticing that late.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

[Rafael J. Wysocki]

On Fri, Mar 19, 2021 at 7:48 PM Pavel Machek <pavel@ucw.cz> wrote:
>
> On Fri 2021-03-19 17:44:32, Rafael J. Wysocki wrote:
> > On Sat, Mar 13, 2021 at 11:27 AM Pavel Machek <pavel@ucw.cz> wrote:
> > >
> > > On Fri 2021-03-12 11:24:30, chris.chiu@canonical.com wrote:
> > > > From: Chris Chiu <chris.chiu@canonical.com>
> > > >
> > > > The .callback of the quirk for Sony VPCEH3U1E was unintetionally
> > > > removed by the commit 25417185e9b5 ("ACPI: video: Add DMI quirk
> > > > for GIGABYTE GB-BXBT-2807"). Add it back to make sure the quirk
> > > > for Sony VPCEH3U1E works as expected.
> > > >
> > > > Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
> > > > Reported-by: Pavel Machek <pavel@ucw.cz>
> > >
> > > Thanks for doing this.
> > >
> > > Reviewed-by: Pavel Machek (CIP) <pavel@denx.de>
> >
> > Applied as 5.12-rc5 material, thanks!
>
> Commit 25417185e9b5 made it into stable, so this one should be Cc:
> stable as well. Sorry for noticing that late.

Well, do you know which -stable series it went into?

I've added a "Cc: stable" tag to this one, but it most likely doesn't
cover all of them.