linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Saravana Kannan <saravanak@google.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.ibm.com>,
	"open list:TARGET SUBSYSTEM" <linux-scsi@vger.kernel.org>,
	Avri Altman <avri.altman@wdc.com>, Bean Huo <huobean@gmail.com>,
	Can Guo <cang@codeaurora.org>,
	Asutosh Das <asutoshd@codeaurora.org>,
	Bart Van Assche <bvanassche@acm.org>,
	Linux PM <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 1/2] driver core: Add ability to delete device links of unregistered devices
Date: Fri, 9 Jul 2021 13:19:37 +0200	[thread overview]
Message-ID: <CAJZ5v0g8fbV6ansDQOM7WchbE3tzvd5iFmnvu2wTOu-F4enM0g@mail.gmail.com> (raw)
In-Reply-To: <YOgdBGBEYNndLLwa@kroah.com>

On Fri, Jul 9, 2021 at 11:55 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, Jul 09, 2021 at 09:43:40AM +0300, Adrian Hunter wrote:
> > Managed device links are deleted by device_del(). However it is possible to
> > add a device link to a consumer before device_add(), and then discover an
> > error prevents the device from being used. In that case normally references
> > to the device would be dropped and the device would be deleted. However the
> > device link holds a reference to the device, so the device link and device
> > remain indefinitely.
>
> Why are you not just manually removing the link you just created?  You
> manually added it, you know something failed so you need to clean up, so
> why not clean this up too?

His changes are needed to do just that.

  reply	other threads:[~2021-07-09 11:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09  6:43 [PATCH V2 0/2] " Adrian Hunter
2021-07-09  6:43 ` [PATCH V2 1/2] " Adrian Hunter
2021-07-09  9:55   ` Greg Kroah-Hartman
2021-07-09 11:19     ` Rafael J. Wysocki [this message]
2021-07-09 11:28   ` Rafael J. Wysocki
2021-07-09 13:18     ` Adrian Hunter
2021-07-09  6:43 ` [PATCH V2 2/2] scsi: ufshcd: Fix device links when BOOT WLUN fails to probe Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZ5v0g8fbV6ansDQOM7WchbE3tzvd5iFmnvu2wTOu-F4enM0g@mail.gmail.com \
    --to=rafael@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=huobean@gmail.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=saravanak@google.com \
    --subject='Re: [PATCH V2 1/2] driver core: Add ability to delete device links of unregistered devices' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).